Re: Review Request 25700: HIVE-8080 CBO: function name may not match UDF name during translation

2014-09-17 Thread Sergey Shelukhin
On Sept. 16, 2014, 5:30 p.m., John Pullokkaran wrote: ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java, line 646 https://reviews.apache.org/r/25700/diff/1/?file=690720#file690720line646 are all functions qualified in hive (w.r.t DB) How about built in functions

Re: Review Request 25700: HIVE-8080 CBO: function name may not match UDF name during translation

2014-09-17 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25700/#review53774 --- Ship it! Ship It! - John Pullokkaran On Sept. 16, 2014, 5:23

Re: Review Request 25700: HIVE-8080 CBO: function name may not match UDF name during translation

2014-09-17 Thread John Pullokkaran
On Sept. 17, 2014, 11:50 p.m., John Pullokkaran wrote: Ship It! Conditional on cbo correctness test pass - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25700/#review53774

Review Request 25700: HIVE-8080 CBO: function name may not match UDF name during translation

2014-09-16 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25700/ --- Review request for hive, Ashutosh Chauhan and John Pullokkaran. Repository:

Re: Review Request 25700: HIVE-8080 CBO: function name may not match UDF name during translation

2014-09-16 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25700/#review53546 --- ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java

Re: Review Request 25700: HIVE-8080 CBO: function name may not match UDF name during translation

2014-09-16 Thread John Pullokkaran
On Sept. 16, 2014, 5:30 p.m., John Pullokkaran wrote: ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java, line 646 https://reviews.apache.org/r/25700/diff/1/?file=690720#file690720line646 are all functions qualified in hive (w.r.t DB) How about built in functions

Re: Review Request 25700: HIVE-8080 CBO: function name may not match UDF name during translation

2014-09-16 Thread Sergey Shelukhin
On Sept. 16, 2014, 5:30 p.m., John Pullokkaran wrote: ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java, line 644 https://reviews.apache.org/r/25700/diff/1/?file=690720#file690720line644 Is hive token case insensitive or all function names are in lower case? see

Re: Review Request 25700: HIVE-8080 CBO: function name may not match UDF name during translation

2014-09-16 Thread Sergey Shelukhin
On Sept. 16, 2014, 5:30 p.m., John Pullokkaran wrote: ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java, line 646 https://reviews.apache.org/r/25700/diff/1/?file=690720#file690720line646 are all functions qualified in hive (w.r.t DB) How about built in functions

Re: Review Request 25700: HIVE-8080 CBO: function name may not match UDF name during translation

2014-09-16 Thread John Pullokkaran
On Sept. 16, 2014, 5:30 p.m., John Pullokkaran wrote: ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java, line 646 https://reviews.apache.org/r/25700/diff/1/?file=690720#file690720line646 are all functions qualified in hive (w.r.t DB) How about built in functions