Re: Review Request 26429: jdbc HTTP configuration options should be part of sessionConf part of connection string

2014-10-10 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26429/#review56211 --- Ship it! Ship It! - Thejas Nair On Oct. 9, 2014, 7:48 a.m.,

Re: Review Request 26429: jdbc HTTP configuration options should be part of sessionConf part of connection string

2014-10-09 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26429/ --- (Updated Oct. 9, 2014, 7:48 a.m.) Review request for hive and Thejas Nair.

Review Request 26429: jdbc HTTP configuration options should be part of sessionConf part of connection string

2014-10-07 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26429/ --- Review request for hive and Thejas Nair. Bugs: HIVE-6972

Re: Review Request 26429: jdbc HTTP configuration options should be part of sessionConf part of connection string

2014-10-07 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26429/ --- (Updated Oct. 7, 2014, 11:50 p.m.) Review request for hive and Thejas Nair.

Re: Review Request 26429: jdbc HTTP configuration options should be part of sessionConf part of connection string

2014-10-07 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26429/#review55733 --- jdbc/src/java/org/apache/hive/jdbc/Utils.java

Re: Review Request 26429: jdbc HTTP configuration options should be part of sessionConf part of connection string

2014-10-07 Thread Vaibhav Gumashta
On Oct. 7, 2014, 11:50 p.m., Thejas Nair wrote: jdbc/src/java/org/apache/hive/jdbc/Utils.java, line 352 https://reviews.apache.org/r/26429/diff/1/?file=714999#file714999line352 A nit - can you move use a static final string for jdbc:hive2://host:port/dbName; Actually I just

Re: Review Request 26429: jdbc HTTP configuration options should be part of sessionConf part of connection string

2014-10-07 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26429/ --- (Updated Oct. 8, 2014, midnight) Review request for hive and Thejas Nair.

Re: Review Request 26429: jdbc HTTP configuration options should be part of sessionConf part of connection string

2014-10-07 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26429/#review55739 --- Ship it! Ship It! - Thejas Nair On Oct. 8, 2014, midnight,