Re: Review Request 26706: HIVE-8436 - Modify SparkWork to split works with multiple child works [Spark Branch]

2014-10-20 Thread Chao Sun
On Oct. 19, 2014, 12:15 a.m., Xuefu Zhang wrote: ql/src/test/queries/clientpositive/spark_multi_insert_split_work.q, line 1 https://reviews.apache.org/r/26706/diff/4/?file=724864#file724864line1 Could we put this test as spark only, as splitting doesn't apply mr or tez? I think

Re: Review Request 26706: HIVE-8436 - Modify SparkWork to split works with multiple child works [Spark Branch]

2014-10-20 Thread Chao Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26706/ --- (Updated Oct. 20, 2014, 5:38 p.m.) Review request for hive and Xuefu Zhang.

Re: Review Request 26706: HIVE-8436 - Modify SparkWork to split works with multiple child works [Spark Branch]

2014-10-20 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26706/#review57412 --- itests/src/test/resources/testconfiguration.properties

Re: Review Request 26706: HIVE-8436 - Modify SparkWork to split works with multiple child works [Spark Branch]

2014-10-20 Thread Chao Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26706/ --- (Updated Oct. 20, 2014, 9:10 p.m.) Review request for hive and Xuefu Zhang.

Re: Review Request 26706: HIVE-8436 - Modify SparkWork to split works with multiple child works [Spark Branch]

2014-10-20 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26706/#review57445 --- itests/src/test/resources/testconfiguration.properties

Re: Review Request 26706: HIVE-8436 - Modify SparkWork to split works with multiple child works [Spark Branch]

2014-10-20 Thread Chao Sun
On Oct. 20, 2014, 9:52 p.m., Xuefu Zhang wrote: itests/src/test/resources/testconfiguration.properties, line 509 https://reviews.apache.org/r/26706/diff/7/?file=726397#file726397line509 We might need to change this as well. Can't believe I missed this. Sorry for the sloppyness! -

Re: Review Request 26706: HIVE-8436 - Modify SparkWork to split works with multiple child works [Spark Branch]

2014-10-20 Thread Chao Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26706/ --- (Updated Oct. 20, 2014, 10:04 p.m.) Review request for hive and Xuefu Zhang.

Re: Review Request 26706: HIVE-8436 - Modify SparkWork to split works with multiple child works [Spark Branch]

2014-10-18 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26706/#review57286 --- ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java

Re: Review Request 26706: HIVE-8436 - Modify SparkWork to split works with multiple child works [Spark Branch]

2014-10-18 Thread Chao Sun
On Oct. 19, 2014, 12:15 a.m., Xuefu Zhang wrote: ql/src/java/org/apache/hadoop/hive/ql/exec/spark/MapInput.java, line 64 https://reviews.apache.org/r/26706/diff/4/?file=724853#file724853line64 Could we reuse this as a utility? I think we have same/similar thing somewhere. You're

Re: Review Request 26706: HIVE-8436 - Modify SparkWork to split works with multiple child works [Spark Branch]

2014-10-18 Thread Chao Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26706/ --- (Updated Oct. 19, 2014, 12:46 a.m.) Review request for hive and Xuefu Zhang.

Re: Review Request 26706: HIVE-8436 - Modify SparkWork to split works with multiple child works [Spark Branch]

2014-10-18 Thread Xuefu Zhang
On Oct. 19, 2014, 12:15 a.m., Xuefu Zhang wrote: ql/src/test/queries/clientpositive/spark_multi_insert_split_work.q, line 1 https://reviews.apache.org/r/26706/diff/4/?file=724864#file724864line1 Could we put this test as spark only, as splitting doesn't apply mr or tez? I think

Re: Review Request 26706: HIVE-8436 - Modify SparkWork to split works with multiple child works [Spark Branch]

2014-10-17 Thread Chao Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26706/ --- (Updated Oct. 17, 2014, 6:04 p.m.) Review request for hive and Xuefu Zhang.

Re: Review Request 26706: HIVE-8436 - Modify SparkWork to split works with multiple child works [Spark Branch]

2014-10-17 Thread Chao Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26706/ --- (Updated Oct. 17, 2014, 9:22 p.m.) Review request for hive and Xuefu Zhang.

Re: Review Request 26706: HIVE-8436 - Modify SparkWork to split works with multiple child works [Spark Branch]

2014-10-17 Thread Chao Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26706/ --- (Updated Oct. 17, 2014, 9:24 p.m.) Review request for hive and Xuefu Zhang.

Re: Review Request 26706: HIVE-8436 - Modify SparkWork to split works with multiple child works [Spark Branch]

2014-10-15 Thread Chao Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26706/ --- (Updated Oct. 16, 2014, 1:25 a.m.) Review request for hive and Xuefu Zhang.

Review Request 26706: HIVE-8436 - Modify SparkWork to split works with multiple child works [Spark Branch]

2014-10-14 Thread Chao Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26706/ --- Review request for hive and Xuefu Zhang. Bugs: HIVE-8436

Re: Review Request 26706: HIVE-8436 - Modify SparkWork to split works with multiple child works [Spark Branch]

2014-10-14 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26706/#review56640 --- ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java

Re: Review Request 26706: HIVE-8436 - Modify SparkWork to split works with multiple child works [Spark Branch]

2014-10-14 Thread Brock Noland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26706/#review56647 ---