Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

2014-10-24 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26721/#review58369 --- Ship it! Ship It! - John Pullokkaran On Oct. 22, 2014, 11:18 p.m

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

2014-10-24 Thread John Pullokkaran
> On Oct. 24, 2014, 8:12 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java, line 346 > > > > > > Can't we use Integer instead of this class? > > Sergey Shelukhin wrote: >

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

2014-10-24 Thread Sergey Shelukhin
> On Oct. 24, 2014, 8:12 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java, line 346 > > > > > > Can't we use Integer instead of this class? integer cannot be used as a ass

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

2014-10-24 Thread Sergey Shelukhin
> On Oct. 24, 2014, 8:11 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java, line 409 > > > > > > ColumnInfo uses internal name; and "internalName"can not be different > > f

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

2014-10-24 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26721/#review58344 --- ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java <

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

2014-10-24 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26721/#review58343 --- ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

2014-10-24 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26721/#review58342 --- ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

2014-10-24 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26721/#review58319 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/AS

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

2014-10-22 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26721/ --- (Updated Oct. 22, 2014, 11:18 p.m.) Review request for hive, Ashutosh Chauhan a

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

2014-10-21 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26721/#review57654 --- ql/src/test/results/clientpositive/tez/cbo_correctness.q.out

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

2014-10-21 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26721/ --- (Updated Oct. 21, 2014, 8:44 p.m.) Review request for hive, Ashutosh Chauhan an

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

2014-10-17 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26721/ --- (Updated Oct. 17, 2014, 11:10 p.m.) Review request for hive, Ashutosh Chauhan a

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

2014-10-17 Thread Sergey Shelukhin
> On Oct. 15, 2014, 9:39 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/reloperators/HiveProjectRel.java, > > line 71 > > > > > > Why are we recomputing the digest here? that u

Re: Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

2014-10-15 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26721/#review56817 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/reloperators/

Review Request 26721: HIVE-8433 CBO loses a column during AST conversion

2014-10-14 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26721/ --- Review request for hive, Ashutosh Chauhan and John Pullokkaran. Repository: hiv