Re: Review Request 27046: HIVE-8545 - Exception when casting Text to BytesWritable [Spark Branch]

2014-10-23 Thread Chao Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27046/ --- (Updated Oct. 23, 2014, 5:32 p.m.) Review request for hive, Brock Noland and

Re: Review Request 27046: HIVE-8545 - Exception when casting Text to BytesWritable [Spark Branch]

2014-10-23 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27046/#review58026 --- Ship it! Ship It! - Xuefu Zhang On Oct. 23, 2014, 5:32 p.m.,

Review Request 27046: HIVE-8545 - Exception when casting Text to BytesWritable [Spark Branch]

2014-10-22 Thread Chao Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27046/ --- Review request for hive, Brock Noland and Xuefu Zhang. Bugs: hive-8545

Re: Review Request 27046: HIVE-8545 - Exception when casting Text to BytesWritable [Spark Branch]

2014-10-22 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27046/#review57929 ---

Re: Review Request 27046: HIVE-8545 - Exception when casting Text to BytesWritable [Spark Branch]

2014-10-22 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27046/#review57932 --- ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTran.java

Re: Review Request 27046: HIVE-8545 - Exception when casting Text to BytesWritable [Spark Branch]

2014-10-22 Thread Chao Sun
On Oct. 22, 2014, 11:40 p.m., Xuefu Zhang wrote: ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTran.java, line 25 https://reviews.apache.org/r/27046/diff/1/?file=728820#file728820line25 Why KO becomes Writable now? Should it be WritableComparable according to MapInput?

Re: Review Request 27046: HIVE-8545 - Exception when casting Text to BytesWritable [Spark Branch]

2014-10-22 Thread Chao Sun
On Oct. 22, 2014, 11:36 p.m., Xuefu Zhang wrote: ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveBaseFunctionResultList.java, line 77 https://reviews.apache.org/r/27046/diff/1/?file=728816#file728816line77 I think we should let this stay in SparkUtils which otherwise now

Re: Review Request 27046: HIVE-8545 - Exception when casting Text to BytesWritable [Spark Branch]

2014-10-22 Thread Chao Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27046/ --- (Updated Oct. 23, 2014, 12:42 a.m.) Review request for hive, Brock Noland and

Re: Review Request 27046: HIVE-8545 - Exception when casting Text to BytesWritable [Spark Branch]

2014-10-22 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27046/#review57962 --- ql/src/java/org/apache/hadoop/hive/ql/exec/spark/MapInput.java