Re: Review Request 27362: Use Apache Curator in JDBC Driver and HiveServer2 for better reliability

2014-10-30 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27362/ --- (Updated Oct. 30, 2014, 8:19 a.m.) Review request for hive and Thejas Nair.

Re: Review Request 27362: Use Apache Curator in JDBC Driver and HiveServer2 for better reliability

2014-10-30 Thread Vaibhav Gumashta
On Oct. 30, 2014, 1:50 a.m., Thejas Nair wrote: service/src/java/org/apache/hive/service/server/HiveServer2.java, line 158 https://reviews.apache.org/r/27362/diff/1/?file=742127#file742127line158 do we need to create parents here ? I feel there's no harm in doing it agn. If parents

Re: Review Request 27362: Use Apache Curator in JDBC Driver and HiveServer2 for better reliability

2014-10-30 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27362/#review59217 --- service/src/java/org/apache/hive/service/server/HiveServer2.java

Re: Review Request 27362: Use Apache Curator in JDBC Driver and HiveServer2 for better reliability

2014-10-30 Thread Vaibhav Gumashta
On Oct. 30, 2014, 4:32 p.m., Thejas Nair wrote: service/src/java/org/apache/hive/service/server/HiveServer2.java, line 387 https://reviews.apache.org/r/27362/diff/2/?file=742775#file742775line387 indentation still needs fixing Checked agn with Thejas. Indentation looks fine. -

Review Request 27362: Use Apache Curator in JDBC Driver and HiveServer2 for better reliability

2014-10-29 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27362/ --- Review request for hive and Thejas Nair. Bugs: HIVE-8664

Re: Review Request 27362: Use Apache Curator in JDBC Driver and HiveServer2 for better reliability

2014-10-29 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27362/#review59104 --- service/src/java/org/apache/hive/service/server/HiveServer2.java