Review Request 28046: HIVE-8840 Print prettier Spark work graph after HIVE-8793 [Spark Branch]

2014-11-14 Thread Jimmy Xiang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28046/ --- Review request for hive and Xuefu Zhang. Bugs: HIVE-8840

Re: Review Request 28046: HIVE-8840 Print prettier Spark work graph after HIVE-8793 [Spark Branch]

2014-11-14 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28046/#review61473 --- ql/src/java/org/apache/hadoop/hive/ql/plan/SparkWork.java

Re: Review Request 28046: HIVE-8840 Print prettier Spark work graph after HIVE-8793 [Spark Branch]

2014-11-14 Thread Jimmy Xiang
On Nov. 14, 2014, 6:51 p.m., Xuefu Zhang wrote: ql/src/java/org/apache/hadoop/hive/ql/plan/SparkWork.java, line 332 https://reviews.apache.org/r/28046/diff/1/?file=763735#file763735line332 Nit: Probably this can be made into the part of for clause for cleanness. Same blow. Sure.

Re: Review Request 28046: HIVE-8840 Print prettier Spark work graph after HIVE-8793 [Spark Branch]

2014-11-14 Thread Jimmy Xiang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28046/ --- (Updated Nov. 14, 2014, 7:32 p.m.) Review request for hive and Xuefu Zhang.

Re: Review Request 28046: HIVE-8840 Print prettier Spark work graph after HIVE-8793 [Spark Branch]

2014-11-14 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28046/#review61498 --- Ship it! Ship It! - Xuefu Zhang On Nov. 14, 2014, 7:32 p.m.,