Re: Review Request 28372: Address review comments

2015-04-29 Thread Ashish Singh
> On April 28, 2015, 9:30 p.m., Ryan Blue wrote: > > Looking good to me. I found a few things to fix, and I'm also wondering > > where the qtest outputs are. Thanks for the review Ryan! qtest outputs are in *.q.out files. - Ashish ---

Re: Review Request 28372: Address review comments

2015-04-28 Thread Ryan Blue
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28372/#review81884 --- Looking good to me. I found a few things to fix, and I'm also wonder

Re: Review Request 28372: Address review comments

2015-04-16 Thread Ashish Singh
> On Dec. 13, 2014, 1:20 a.m., Ryan Blue wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ParquetHiveSerDe.java, > > line 138 > > > > > > I'd rather not use parquet.file at all. Is there a compelling

Re: Review Request 28372: Address review comments

2015-04-16 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28372/ --- (Updated April 17, 2015, 3:01 a.m.) Review request for hive. Changes ---