Re: Review Request 28889: HIVE-8911 - Enable mapjoin hints [Spark Branch]

2014-12-12 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28889/#review64959 --- Patch looks good. One suggestion, we should be able to change the

Re: Review Request 28889: HIVE-8911 - Enable mapjoin hints [Spark Branch]

2014-12-12 Thread Chao Sun
On Dec. 12, 2014, 7:45 p.m., Xuefu Zhang wrote: ql/src/java/org/apache/hadoop/hive/ql/optimizer/SparkMapJoinProcessor.java, line 78 https://reviews.apache.org/r/28889/diff/2/?file=789801#file789801line78 nit: grandParentOps.get(0) is repeated in the next line. nice to have a

Re: Review Request 28889: HIVE-8911 - Enable mapjoin hints [Spark Branch]

2014-12-12 Thread Chao Sun
On Dec. 12, 2014, 7:45 p.m., Xuefu Zhang wrote: Patch looks good. One suggestion, we should be able to change the static methods non-static, which would further simplify the code. I agree. Let me change it. - Chao --- This is an

Re: Review Request 28889: HIVE-8911 - Enable mapjoin hints [Spark Branch]

2014-12-12 Thread Chao Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28889/ --- (Updated Dec. 13, 2014, 12:24 a.m.) Review request for hive, Szehon Ho and

Re: Review Request 28889: HIVE-8911 - Enable mapjoin hints [Spark Branch]

2014-12-11 Thread Chao Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28889/ --- (Updated Dec. 11, 2014, 10:36 p.m.) Review request for hive, Szehon Ho and

Review Request 28889: HIVE-8911 - Enable mapjoin hints [Spark Branch]

2014-12-09 Thread Chao Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28889/ --- Review request for hive, Szehon Ho and Xuefu Zhang. Bugs: HIVE-8911