Re: Review Request 29900: HIVE-5472 support a simple scalar which returns the current timestamp

2015-01-28 Thread Alexander Pivovarov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29900/#review70130 --- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCurrent

Re: Review Request 29900: HIVE-5472 support a simple scalar which returns the current timestamp

2015-01-28 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29900/#review70128 --- Ship it! Ship It! - Thejas Nair On Jan. 28, 2015, 11:22 p.m., Ja

Re: Review Request 29900: HIVE-5472 support a simple scalar which returns the current timestamp

2015-01-28 Thread Thejas Nair
> On Jan. 28, 2015, 8:40 p.m., Thejas Nair wrote: > > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java, line 1404 > > > > > > I have seen at least another place where we have a test timestamp > > getti

Re: Review Request 29900: HIVE-5472 support a simple scalar which returns the current timestamp

2015-01-28 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29900/ --- (Updated Jan. 28, 2015, 11:22 p.m.) Review request for hive and Thejas Nair.

Re: Review Request 29900: HIVE-5472 support a simple scalar which returns the current timestamp

2015-01-28 Thread Jason Dere
> On Jan. 28, 2015, 8:40 p.m., Thejas Nair wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 841 > > > > > > we should add a boolean false argument at the end here, so that it does > > not sho

Re: Review Request 29900: HIVE-5472 support a simple scalar which returns the current timestamp

2015-01-28 Thread Jason Dere
> On Jan. 28, 2015, 9:05 p.m., Alexander Pivovarov wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCurrentDate.java, > > line 47 > > > > > > //you can use substring(0, 10) to get date part of the

Re: Review Request 29900: HIVE-5472 support a simple scalar which returns the current timestamp

2015-01-28 Thread Alexander Pivovarov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29900/#review70083 --- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCurrent

Re: Review Request 29900: HIVE-5472 support a simple scalar which returns the current timestamp

2015-01-28 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29900/#review70062 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java

Re: Review Request 29900: HIVE-5472 support a simple scalar which returns the current timestamp

2015-01-19 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29900/ --- (Updated Jan. 19, 2015, 10:01 p.m.) Review request for hive and Thejas Nair.

Review Request 29900: HIVE-5472 support a simple scalar which returns the current timestamp

2015-01-14 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29900/ --- Review request for hive and Thejas Nair. Bugs: HIVE-5472 https://issues.apa