---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33422/#review81520
---
Ship it!
Ship It!
- Marcelo Vanzin
On April 23, 2015, 6:54
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33422/
---
(Updated April 23, 2015, 6:11 p.m.)
Review request for hive and Marcelo
On April 23, 2015, 4:55 p.m., Marcelo Vanzin wrote:
spark-client/src/main/java/org/apache/hive/spark/client/rpc/RpcServer.java,
line 172
https://reviews.apache.org/r/33422/diff/2/?file=939013#file939013line172
To avoid races, I'd do:
final ClientInfo cinfo =
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33422/#review81328
---
Ship it!
Just a minor thing left to fix.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33422/
---
(Updated April 23, 2015, 6:54 p.m.)
Review request for hive and Marcelo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33422/#review81361
---
On April 23, 2015, 6:22 p.m., Xuefu Zhang wrote:
spark-client/src/main/java/org/apache/hive/spark/client/rpc/RpcServer.java,
line 176
https://reviews.apache.org/r/33422/diff/2/?file=939013#file939013line176
I'm wondering if cinfo can be null here. After the contains() check
On April 23, 2015, 6:22 p.m., Xuefu Zhang wrote:
spark-client/src/main/java/org/apache/hive/spark/client/rpc/RpcServer.java,
line 176
https://reviews.apache.org/r/33422/diff/2/?file=939013#file939013line176
I'm wondering if cinfo can be null here. After the contains() check
On April 22, 2015, 12:38 a.m., Marcelo Vanzin wrote:
spark-client/src/main/java/org/apache/hive/spark/client/rpc/RpcServer.java,
line 172
https://reviews.apache.org/r/33422/diff/1/?file=938965#file938965line172
This will throw an exception if the child process exits with a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33422/
---
(Updated April 22, 2015, 1:25 a.m.)
Review request for hive and Marcelo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33422/
---
Review request for hive and Marcelo Vanzin.
Bugs: HIVE-10434
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33422/#review81103
---
12 matches
Mail list logo