Re: Review Request 33422: HIVE-10434 - Cancel connection when remote Spark driver process has failed [Spark Branch]

2015-04-24 Thread Marcelo Vanzin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33422/#review81520 --- Ship it! Ship It! - Marcelo Vanzin On April 23, 2015, 6:54

Re: Review Request 33422: HIVE-10434 - Cancel connection when remote Spark driver process has failed [Spark Branch]

2015-04-23 Thread Chao Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33422/ --- (Updated April 23, 2015, 6:11 p.m.) Review request for hive and Marcelo

Re: Review Request 33422: HIVE-10434 - Cancel connection when remote Spark driver process has failed [Spark Branch]

2015-04-23 Thread Chao Sun
On April 23, 2015, 4:55 p.m., Marcelo Vanzin wrote: spark-client/src/main/java/org/apache/hive/spark/client/rpc/RpcServer.java, line 172 https://reviews.apache.org/r/33422/diff/2/?file=939013#file939013line172 To avoid races, I'd do: final ClientInfo cinfo =

Re: Review Request 33422: HIVE-10434 - Cancel connection when remote Spark driver process has failed [Spark Branch]

2015-04-23 Thread Marcelo Vanzin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33422/#review81328 --- Ship it! Just a minor thing left to fix.

Re: Review Request 33422: HIVE-10434 - Cancel connection when remote Spark driver process has failed [Spark Branch]

2015-04-23 Thread Chao Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33422/ --- (Updated April 23, 2015, 6:54 p.m.) Review request for hive and Marcelo

Re: Review Request 33422: HIVE-10434 - Cancel connection when remote Spark driver process has failed [Spark Branch]

2015-04-23 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33422/#review81361 ---

Re: Review Request 33422: HIVE-10434 - Cancel connection when remote Spark driver process has failed [Spark Branch]

2015-04-23 Thread Chao Sun
On April 23, 2015, 6:22 p.m., Xuefu Zhang wrote: spark-client/src/main/java/org/apache/hive/spark/client/rpc/RpcServer.java, line 176 https://reviews.apache.org/r/33422/diff/2/?file=939013#file939013line176 I'm wondering if cinfo can be null here. After the contains() check

Re: Review Request 33422: HIVE-10434 - Cancel connection when remote Spark driver process has failed [Spark Branch]

2015-04-23 Thread Marcelo Vanzin
On April 23, 2015, 6:22 p.m., Xuefu Zhang wrote: spark-client/src/main/java/org/apache/hive/spark/client/rpc/RpcServer.java, line 176 https://reviews.apache.org/r/33422/diff/2/?file=939013#file939013line176 I'm wondering if cinfo can be null here. After the contains() check

Re: Review Request 33422: HIVE-10434 - Cancel connection when remote Spark driver process has failed [Spark Branch]

2015-04-21 Thread Chao Sun
On April 22, 2015, 12:38 a.m., Marcelo Vanzin wrote: spark-client/src/main/java/org/apache/hive/spark/client/rpc/RpcServer.java, line 172 https://reviews.apache.org/r/33422/diff/1/?file=938965#file938965line172 This will throw an exception if the child process exits with a

Re: Review Request 33422: HIVE-10434 - Cancel connection when remote Spark driver process has failed [Spark Branch]

2015-04-21 Thread Chao Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33422/ --- (Updated April 22, 2015, 1:25 a.m.) Review request for hive and Marcelo

Review Request 33422: HIVE-10434 - Cancel connection when remote Spark driver process has failed [Spark Branch]

2015-04-21 Thread Chao Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33422/ --- Review request for hive and Marcelo Vanzin. Bugs: HIVE-10434

Re: Review Request 33422: HIVE-10434 - Cancel connection when remote Spark driver process has failed [Spark Branch]

2015-04-21 Thread Marcelo Vanzin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33422/#review81103 ---