Review Request 34757: HIVE-10844: Combine equivalent Works for HoS[Spark Branch]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34757/ --- Review request for hive and Xuefu Zhang. Bugs: HIVE-10844 https://issues.ap

Re: Review Request 34757: HIVE-10844: Combine equivalent Works for HoS[Spark Branch]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34757/ --- (Updated June 17, 2015, 8:59 a.m.) Review request for hive and Xuefu Zhang. C

Re: Review Request 34757: HIVE-10844: Combine equivalent Works for HoS[Spark Branch]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34757/#review88484 --- !. First round review. Only at a high level. 2. Patch looks very goo

Re: Review Request 34757: HIVE-10844: Combine equivalent Works for HoS[Spark Branch]

> On June 19, 2015, 3:42 a.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/CombineEquivalentWorkResolver.java, > > line 207 > > > > > > I think in SparkWork, there couldn't be two pare

Re: Review Request 34757: HIVE-10844: Combine equivalent Works for HoS[Spark Branch]

> On June 19, 2015, 3:42 a.m., Xuefu Zhang wrote: > > !. First round review. Only at a high level. > > 2. Patch looks very good and clean. > > 3. It will be better if we can add some test cases for self union, > > self-join, CWE, and repeated sub-queries. This can be a followup task, > > though

Re: Review Request 34757: HIVE-10844: Combine equivalent Works for HoS[Spark Branch]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34757/ --- (Updated June 19, 2015, 7:22 a.m.) Review request for hive and Xuefu Zhang. C

Re: Review Request 34757: HIVE-10844: Combine equivalent Works for HoS[Spark Branch]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34757/#review88537 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/OperatorComparatorF

Re: Review Request 34757: HIVE-10844: Combine equivalent Works for HoS[Spark Branch]

> On June 19, 2015, 3:42 a.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/CombineEquivalentWorkResolver.java, > > line 207 > > > > > > I think in SparkWork, there couldn't be two pare

Re: Review Request 34757: HIVE-10844: Combine equivalent Works for HoS[Spark Branch]

> On 六月 19, 2015, 3:42 a.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/CombineEquivalentWorkResolver.java, > > line 207 > > > > > > I think in SparkWork, there couldn't be two parent

Re: Review Request 34757: HIVE-10844: Combine equivalent Works for HoS[Spark Branch]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34757/ --- (Updated June 23, 2015, 7:24 a.m.) Review request for hive and Xuefu Zhang. C

Re: Review Request 34757: HIVE-10844: Combine equivalent Works for HoS[Spark Branch]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34757/#review88966 --- ql/src/test/results/clientpositive/spark/groupby10.q.out (line 60)

Re: Review Request 34757: HIVE-10844: Combine equivalent Works for HoS[Spark Branch]

> On 六月 19, 2015, 1:47 p.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/CombineEquivalentWorkResolver.java, > > line 98 > > > > > > I think the recursion should go on even if there is

Re: Review Request 34757: HIVE-10844: Combine equivalent Works for HoS[Spark Branch]

> On 六月 23, 2015, 1:31 p.m., Xuefu Zhang wrote: > > ql/src/test/results/clientpositive/spark/groupby10.q.out, line 60 > > > > > > Interesting. How come we got more stages now? Not sure, introduced by latest merge fro

Re: Review Request 34757: HIVE-10844: Combine equivalent Works for HoS[Spark Branch]

> On June 23, 2015, 1:31 p.m., Xuefu Zhang wrote: > > ql/src/test/results/clientpositive/spark/groupby10.q.out, line 60 > > > > > > Interesting. How come we got more stages now? > > chengxiang li wrote: > Not sur

Re: Review Request 34757: HIVE-10844: Combine equivalent Works for HoS[Spark Branch]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34757/#review89155 --- Ship it! - Xuefu Zhang On June 23, 2015, 7:24 a.m., chengxiang li