Re: Review Request 42508: HIVE-12889: Support COUNT(DISTINCT) for partitioning query.

2016-01-26 Thread Aihua Xu
> On Jan. 25, 2016, 11:30 p.m., Szehon Ho wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCount.java, > > line 120 > > > > > > What is manager? And also nit to remove the whitespace at end.

Re: Review Request 42508: HIVE-12889: Support COUNT(DISTINCT) for partitioning query.

2016-01-25 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42508/#review116218 --- Fix it, then Ship it! Looks a lot cleaner, great that it works.

Re: Review Request 42508: HIVE-12889: Support COUNT(DISTINCT) for partitioning query.

2016-01-25 Thread Aihua Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42508/ --- (Updated Jan. 25, 2016, 4:36 p.m.) Review request for hive, Chaoyu Tang, Szehon

Re: Review Request 42508: HIVE-12889: Support COUNT(DISTINCT) for partitioning query.

2016-01-22 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42508/#review115951 --- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCoun

Re: Review Request 42508: HIVE-12889: Support COUNT(DISTINCT) for partitioning query.

2016-01-22 Thread Aihua Xu
> On Jan. 22, 2016, 8:04 a.m., Szehon Ho wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCount.java, > > line 161 > > > > > > Why do we need to do ArrayUtils.isEquals as well as hash comparis

Re: Review Request 42508: HIVE-12889: Support COUNT(DISTINCT) for partitioning query.

2016-01-22 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42508/#review115804 --- Overall logic makes sense.. just some (maybe basic) questions below

Re: Review Request 42508: HIVE-12889: Support COUNT(DISTINCT) for partitioning query.

2016-01-20 Thread Aihua Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42508/ --- (Updated Jan. 20, 2016, 5:05 p.m.) Review request for hive, Chaoyu Tang, Szehon

Review Request 42508: HIVE-12889: Support COUNT(DISTINCT) for partitioning query.

2016-01-19 Thread Aihua Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42508/ --- Review request for hive, Chaoyu Tang, Szehon Ho, and Xuefu Zhang. Repository: h