Re: Review Request 49952: HIVE-14205: Hive doesn't support union type with AVRO file format

2016-07-19 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49952/#review142836 --- Ship it! LGTM, +1 - Chaoyu Tang On July 19, 2016, 12:56 a.m.

Re: Review Request 49952: HIVE-14205: Hive doesn't support union type with AVRO file format

2016-07-18 Thread Yibing Shi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49952/ --- (Updated July 19, 2016, 10:56 a.m.) Review request for hive and Chaoyu Tang.

Re: Review Request 49952: HIVE-14205: Hive doesn't support union type with AVRO file format

2016-07-16 Thread Yibing Shi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49952/ --- (Updated July 16, 2016, 9:04 p.m.) Review request for hive and Chaoyu Tang. C

Re: Review Request 49952: HIVE-14205: Hive doesn't support union type with AVRO file format

2016-07-13 Thread Yibing Shi
> On July 13, 2016, 11:11 a.m., Chaoyu Tang wrote: > > Thanks [~yshi] for patch. It looks good. But I have a couple of questions: > > It seems to me that the union in existing code is only used to support > > Nullable type in Avro, and has not been fully supported as a data type in > > general.

Re: Review Request 49952: HIVE-14205: Hive doesn't support union type with AVRO file format

2016-07-12 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49952/#review141997 --- Thanks [~yshi] for patch. It looks good. But I have a couple of qu

Review Request 49952: HIVE-14205: Hive doesn't support union type with AVRO file format

2016-07-12 Thread Yibing Shi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49952/ --- Review request for hive. Bugs: HIVE-14205 https://issues.apache.org/jira/br