Re: Review Request 55623: HIVE-15617: Improve the avg performance for Range based window

> On Jan. 17, 2017, 3:46 p.m., Yongzhi Chen wrote: > > > > Yongzhi Chen wrote: > Could you add a test case which range size is 0 for avg ? We already have those kind of cases in existing test cases, for example, in windowing_windowspec3.q, select deptno, empno, bonus, avg(bonus)

Re: Review Request 55623: HIVE-15617: Improve the avg performance for Range based window

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55623/#review162147 --- Ship it! Ship It! - Yongzhi Chen On Jan. 17, 2017, 3:02

Re: Review Request 55623: HIVE-15617: Improve the avg performance for Range based window

> On Jan. 17, 2017, 3:46 p.m., Yongzhi Chen wrote: > > Could you add a test case which range size is 0 for avg ? - Yongzhi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55623/#review161875

Re: Review Request 55623: HIVE-15617: Improve the avg performance for Range based window

> On Jan. 17, 2017, 3:46 p.m., Yongzhi Chen wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/BasePartitionEvaluator.java, > > line 132 > > > > > > Is that possible sum is not null, numRows == 0 ? I was

Re: Review Request 55623: HIVE-15617: Improve the avg performance for Range based window

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55623/#review161875 ---

Review Request 55623: HIVE-15617: Improve the avg performance for Range based window

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55623/ --- Review request for hive. Repository: hive-git Description ---