Re: Review Request 59885: HIVE-16844: Fix Connection leak in ObjectStore when new Conf object is used

2017-06-08 Thread Anthony Hsu via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59885/#review177432 --- Ship it! Looks good to me. - Anthony Hsu On 六月 7, 2017, 4:29

Re: Review Request 59885: HIVE-16844: Fix Connection leak in ObjectStore when new Conf object is used

2017-06-08 Thread Anthony Hsu via Review Board
> On 六月 7, 2017, 8:45 p.m., Anthony Hsu wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Line 302 (original), 304 (patched) > > > > > > Do we need to close the PersistenceManager as

Re: Review Request 59885: HIVE-16844: Fix Connection leak in ObjectStore when new Conf object is used

2017-06-07 Thread Sunitha Beeram via Review Board
> On June 7, 2017, 8:45 p.m., Anthony Hsu wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Line 302 (original), 304 (patched) > > > > > > Do we need to close the PersistenceManager

Re: Review Request 59885: HIVE-16844: Fix Connection leak in ObjectStore when new Conf object is used

2017-06-07 Thread Anthony Hsu via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59885/#review177222 --- metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.j

Review Request 59885: HIVE-16844: Fix Connection leak in ObjectStore when new Conf object is used

2017-06-07 Thread Sunitha Beeram via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59885/ --- Review request for hive, Carl Steinbach, Anthony Hsu, and Ratandeep Ratti. Bugs