Re: Review Request 60432: HIVE-16845: INSERT OVERWRITE a table with dynamic partitions on S3 fails with NPE

2017-07-14 Thread Sahil Takiar
> On July 11, 2017, 11:14 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java > > Lines 305-308 (patched) > > > > > > Is the if statement necessary? Is there a

Re: Review Request 60432: HIVE-16845: INSERT OVERWRITE a table with dynamic partitions on S3 fails with NPE

2017-07-13 Thread Marta Kuczora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60432/ --- (Updated July 13, 2017, 3:05 p.m.) Review request for hive and Sergio Pena.

Re: Review Request 60432: HIVE-16845: INSERT OVERWRITE a table with dynamic partitions on S3 fails with NPE

2017-07-13 Thread Marta Kuczora
> On July 11, 2017, 11:14 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java > > Lines 305-308 (patched) > > > > > > Is the if statement necessary? Is there a

Re: Review Request 60432: HIVE-16845: INSERT OVERWRITE a table with dynamic partitions on S3 fails with NPE

2017-07-13 Thread Marta Kuczora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60432/ --- (Updated July 13, 2017, 2:58 p.m.) Review request for hive and Sergio Pena.

Re: Review Request 60432: HIVE-16845: INSERT OVERWRITE a table with dynamic partitions on S3 fails with NPE

2017-07-12 Thread Marta Kuczora
> On July 11, 2017, 11:14 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java > > Lines 305-308 (patched) > > > > > > Is the if statement necessary? Is there a

Re: Review Request 60432: HIVE-16845: INSERT OVERWRITE a table with dynamic partitions on S3 fails with NPE

2017-07-11 Thread Sahil Takiar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60432/#review180254 ---

Re: Review Request 60432: HIVE-16845: INSERT OVERWRITE a table with dynamic partitions on S3 fails with NPE

2017-06-27 Thread Marta Kuczora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60432/ --- (Updated June 27, 2017, 1:02 p.m.) Review request for hive and Sergio Pena.

Re: Review Request 60432: HIVE-16845: INSERT OVERWRITE a table with dynamic partitions on S3 fails with NPE

2017-06-26 Thread Marta Kuczora
> On June 26, 2017, 2:53 p.m., Barna Zsombor Klara wrote: > > Thank you for the review Marta, I just had one comment. > > Also do you think it makes sense to add tests for HoS as well or is this > > problem only MR related? Thanks a lot for the review. That's a good question. I don't think

Re: Review Request 60432: HIVE-16845: INSERT OVERWRITE a table with dynamic partitions on S3 fails with NPE

2017-06-26 Thread Barna Zsombor Klara
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60432/#review178891 --- Thank you for the review Marta, I just had one comment. Also do

Review Request 60432: HIVE-16845: INSERT OVERWRITE a table with dynamic partitions on S3 fails with NPE

2017-06-26 Thread Marta Kuczora
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60432/ --- Review request for hive and Sergio Pena. Bugs: HIVE-16845