Re: Review Request 60468: HIVE-16888

2017-07-13 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60468/ --- (Updated July 13, 2017, 11:41 a.m.) Review request for hive and Ashutosh Chauha

Re: Review Request 60468: HIVE-16888

2017-07-13 Thread Jesús Camacho Rodríguez
> On July 11, 2017, 6:21 p.m., Slim Bouguerra wrote: > > ql/src/test/results/clientpositive/druid_intervals.q.out > > Lines 142-143 (original), 142-143 (patched) > > > > > > same as issue above seems we have a change

Re: Review Request 60468: HIVE-16888

2017-07-11 Thread Jesús Camacho Rodríguez
> On July 10, 2017, 10:05 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/ppd_union.q.out > > Line 31 (original), 31 (patched) > > > > > > I am not sure if this filter simplification is correct fo

Re: Review Request 60468: HIVE-16888

2017-07-11 Thread Jesús Camacho Rodríguez
> On July 10, 2017, 10:05 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/vector_date_1.q.out > > Line 594 (original), 594 (patched) > > > > > > seems like predicate: and (dt1 > 1970-01-01) and (

Re: Review Request 60468: HIVE-16888

2017-07-11 Thread Ashutosh Chauhan
> On July 10, 2017, 10:05 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/druid_basic2.q.out > > Line 837 (original), 837 (patched) > > > > > > Is this correct: extraction function should have be

Re: Review Request 60468: HIVE-16888

2017-07-11 Thread Slim Bouguerra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60468/#review180228 --- ql/src/test/results/clientpositive/druid_intervals.q.out Line 112

Re: Review Request 60468: HIVE-16888

2017-07-10 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60468/#review180071 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translato

Re: Review Request 60468: HIVE-16888

2017-06-28 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60468/ --- (Updated June 28, 2017, 7:56 a.m.) Review request for hive and Ashutosh Chauhan

Review Request 60468: HIVE-16888

2017-06-27 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60468/ --- Review request for hive and Ashutosh Chauhan. Bugs: HIVE-16888 https://issu