Re: Review Request 60753: Add HLL as an alternative to FM sketch to compute stats

2017-07-14 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60753/ --- (Updated July 14, 2017, 9:02 p.m.) Review request for hive, Ashutosh Chauhan

Re: Review Request 60753: Add HLL as an alternative to FM sketch to compute stats

2017-07-14 Thread Ashutosh Chauhan
> On July 14, 2017, 12:55 a.m., Ashutosh Chauhan wrote: > > common/src/java/org/apache/hadoop/hive/common/ndv/NumDistinctValueEstimatorFactory.java > > Lines 30-34 (patched) > > > > > > As discussed this

Re: Review Request 60753: Add HLL as an alternative to FM sketch to compute stats

2017-07-14 Thread pengcheng xiong
> On July 14, 2017, 12:55 a.m., Ashutosh Chauhan wrote: > > common/src/java/org/apache/hadoop/hive/common/ndv/NumDistinctValueEstimatorFactory.java > > Lines 30-34 (patched) > > > > > > As discussed this

Re: Review Request 60753: Add HLL as an alternative to FM sketch to compute stats

2017-07-14 Thread j . prasanth . j
> On July 14, 2017, 12:55 a.m., Ashutosh Chauhan wrote: > > common/src/java/org/apache/hadoop/hive/common/ndv/hll/HLLSparseRegister.java > > Lines 28-30 (patched) > > > > > > Is it really worth to have a dependency

Re: Review Request 60753: Add HLL as an alternative to FM sketch to compute stats

2017-07-13 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60753/#review180508 ---

Re: Review Request 60753: Add HLL as an alternative to FM sketch to compute stats

2017-07-13 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60753/#review180494 --- common/pom.xml Lines 234-238 (patched)

Re: Review Request 60753: Add HLL as an alternative to FM sketch to compute stats

2017-07-13 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60753/ --- (Updated July 14, 2017, 12:08 a.m.) Review request for hive, Ashutosh Chauhan

Re: Review Request 60753: Add HLL as an alternative to FM sketch to compute stats

2017-07-13 Thread Andrew Sherman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60753/#review180428 --- Comment "Copyright 2017 Prasanth Jayachandran" in

Re: Review Request 60753: Add HLL as an alternative to FM sketch to compute stats

2017-07-12 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60753/ --- (Updated July 13, 2017, 12:12 a.m.) Review request for hive, Ashutosh Chauhan

Re: Review Request 60753: Add HLL as an alternative to FM sketch to compute stats

2017-07-11 Thread Lefty Leverenz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60753/#review180255 --- Typo: The RB description says "HIVE-16966" but it should be

Re: Review Request 60753: Add HLL as an alternative to FM sketch to compute stats

2017-07-11 Thread pengcheng xiong
> On July 10, 2017, 10:02 p.m., Prasanth_J wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Line 1723 (original), 1723 (patched) > > > > > > I am not sure if we need this config. > >

Re: Review Request 60753: Add HLL as an alternative to FM sketch to compute stats

2017-07-11 Thread Ashutosh Chauhan
> On July 10, 2017, 10:02 p.m., Prasanth_J wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Line 1723 (original), 1723 (patched) > > > > > > I am not sure if we need this config. > >

Re: Review Request 60753: Add HLL as an alternative to FM sketch to compute stats

2017-07-11 Thread Ashutosh Chauhan
> On July 10, 2017, 10:02 p.m., Prasanth_J wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Line 1723 (original), 1723 (patched) > > > > > > I am not sure if we need this config. > >

Re: Review Request 60753: Add HLL as an alternative to FM sketch to compute stats

2017-07-10 Thread j . prasanth . j
> On July 10, 2017, 10:02 p.m., Prasanth_J wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Line 1723 (original), 1723 (patched) > > > > > > I am not sure if we need this config. > >

Re: Review Request 60753: Add HLL as an alternative to FM sketch to compute stats

2017-07-10 Thread pengcheng xiong
> On July 10, 2017, 10:02 p.m., Prasanth_J wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Line 1723 (original), 1723 (patched) > > > > > > I am not sure if we need this config. > >

Re: Review Request 60753: Add HLL as an alternative to FM sketch to compute stats

2017-07-10 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60753/#review180119 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Line

Re: Review Request 60753: Add HLL as an alternative to FM sketch to compute stats

2017-07-10 Thread pengcheng xiong
> On July 10, 2017, 9:42 p.m., Prasanth_J wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Line 1723 (original), 1723 (patched) > > > > > > Does this mean any positive value will use FM

Re: Review Request 60753: Add HLL as an alternative to FM sketch to compute stats

2017-07-10 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60753/#review180111 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Line

Review Request 60753: Add HLL as an alternative to FM sketch to compute stats

2017-07-10 Thread pengcheng xiong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60753/ --- Review request for hive, Ashutosh Chauhan and Prasanth_J. Repository: hive-git