Re: Review Request 61010: HIVE-17128 Operation Logging leaks file descriptors as the log4j Appender is never closed

2017-07-25 Thread Peter Vary
> On July 24, 2017, 9:09 a.m., Peter Vary wrote: > > itests/hive-unit/src/test/java/org/apache/hive/service/cli/operation/TestOperationLoggingLayout.java > > Line 123 (original), 124 (patched) > > > > > > I might b

Re: Review Request 61010: HIVE-17128 Operation Logging leaks file descriptors as the log4j Appender is never closed

2017-07-25 Thread Peter Vary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61010/#review181326 --- Ship it! Ship It! - Peter Vary On July 22, 2017, 12:16 a.m.,

Re: Review Request 61010: HIVE-17128 Operation Logging leaks file descriptors as the log4j Appender is never closed

2017-07-24 Thread Andrew Sherman
> On July 24, 2017, 9:09 a.m., Peter Vary wrote: > > itests/hive-unit/src/test/java/org/apache/hive/service/cli/operation/TestOperationLoggingLayout.java > > Line 123 (original), 124 (patched) > > > > > > I might b

Re: Review Request 61010: HIVE-17128 Operation Logging leaks file descriptors as the log4j Appender is never closed

2017-07-24 Thread Peter Vary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61010/#review181196 --- Just 2 comments and they are not that important. Feel free to tell

Re: Review Request 61010: HIVE-17128 Operation Logging leaks file descriptors as the log4j Appender is never closed

2017-07-21 Thread Andrew Sherman
> On July 20, 2017, 11:59 p.m., Aihua Xu wrote: > > service/src/java/org/apache/hive/service/cli/operation/Operation.java > > Lines 269 (patched) > > > > > > We only register the Operation log appender once for all t

Re: Review Request 61010: HIVE-17128 Operation Logging leaks file descriptors as the log4j Appender is never closed

2017-07-21 Thread Andrew Sherman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61010/ --- (Updated July 22, 2017, 12:16 a.m.) Review request for hive. Repository: hive

Re: Review Request 61010: HIVE-17128 Operation Logging leaks file descriptors as the log4j Appender is never closed

2017-07-21 Thread Aihua Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61010/#review181158 --- Ship it! Ship It! - Aihua Xu On July 20, 2017, 10:45 p.m., A

Re: Review Request 61010: HIVE-17128 Operation Logging leaks file descriptors as the log4j Appender is never closed

2017-07-21 Thread Aihua Xu
> On July 20, 2017, 11:59 p.m., Aihua Xu wrote: > > service/src/java/org/apache/hive/service/cli/operation/Operation.java > > Lines 269 (patched) > > > > > > We only register the Operation log appender once for all t

Re: Review Request 61010: HIVE-17128 Operation Logging leaks file descriptors as the log4j Appender is never closed

2017-07-21 Thread Andrew Sherman
> On July 20, 2017, 11:59 p.m., Aihua Xu wrote: > > service/src/java/org/apache/hive/service/cli/operation/Operation.java > > Lines 269 (patched) > > > > > > We only register the Operation log appender once for all t

Re: Review Request 61010: HIVE-17128 Operation Logging leaks file descriptors as the log4j Appender is never closed

2017-07-21 Thread Peter Vary
> On July 20, 2017, 11:59 p.m., Aihua Xu wrote: > > service/src/java/org/apache/hive/service/cli/operation/Operation.java > > Lines 269 (patched) > > > > > > We only register the Operation log appender once for all t

Re: Review Request 61010: HIVE-17128 Operation Logging leaks file descriptors as the log4j Appender is never closed

2017-07-20 Thread Aihua Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61010/#review181083 --- service/src/java/org/apache/hive/service/cli/operation/Operation.

Review Request 61010: HIVE-17128 Operation Logging leaks file descriptors as the log4j Appender is never closed

2017-07-20 Thread Andrew Sherman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61010/ --- Review request for hive. Repository: hive-git Description --- Previously