----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68850/ -----------------------------------------------------------
Review request for hive and Ashutosh Chauhan. Bugs: HIVE-20637 https://issues.apache.org/jira/browse/HIVE-20637 Repository: hive-git Description ------- Allow any udfs with 0 arguments or with constant arguments as part of default clause Also removed some unused code. Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java b655ab1 ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 412fca2 ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 344e9fc ql/src/test/queries/clientnegative/default_constraint_invalid_default_value2.q ec5b67a ql/src/test/queries/clientnegative/default_constraint_invalid_default_value_type.q 1f1a9db ql/src/test/queries/clientpositive/insert_into_default_keyword.q ebef1a4 ql/src/test/results/clientnegative/default_constraint_invalid_default_value2.q.out 76e5aeb ql/src/test/results/clientnegative/default_constraint_invalid_default_value_type.q.out 61e0a2f ql/src/test/results/clientpositive/llap/insert_into_default_keyword.q.out 4f4d1b1 Diff: https://reviews.apache.org/r/68850/diff/1/ Testing ------- Tested on local cluster. Added a new section in a q test, and removed those test that were testing especially this not to happen. Thanks, Miklos Gergely