Re: Review Request 69562: HIVE-16957

2018-12-21 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69562/ --- (Updated Dec. 21, 2018, 8:30 p.m.) Review request for hive and Ashutosh

Re: Review Request 69562: HIVE-16957

2018-12-21 Thread Jesús Camacho Rodríguez
> On Dec. 21, 2018, 5:12 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsAutoGatherContext.java > > Lines 110 (patched) > > > > > > It will be good to add a comment here

Re: Review Request 69562: HIVE-16957

2018-12-21 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69562/#review211502 ---

Re: Review Request 69562: HIVE-16957

2018-12-21 Thread Jesús Camacho Rodríguez
> On Dec. 20, 2018, 7:56 p.m., Ashutosh Chauhan wrote: > > ql/src/test/queries/clientpositive/cbo_rp_cross_product_check_2.q > > Line 7 (original), 7 (patched) > > > > > > Is it necessary to specify schema to get

Re: Review Request 69562: HIVE-16957

2018-12-20 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69562/#review211472 ---

Re: Review Request 69562: HIVE-16957

2018-12-13 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69562/ --- (Updated Dec. 13, 2018, 4:50 p.m.) Review request for hive and Ashutosh

Review Request 69562: HIVE-16957

2018-12-12 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69562/ --- Review request for hive and Ashutosh Chauhan. Bugs: HIVE-16957