----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71760/ -----------------------------------------------------------
Review request for hive. Bugs: HIVE-21146 https://issues.apache.org/jira/browse/HIVE-21146 Repository: hive-git Description ------- Streaming Ingest API supports a concept of TransactionBatch where N transactions can be opened at once and the data in all of them will be written to the same delta_x_y directory where each transaction in the batch can be committed/aborted independently. The implementation relies on FSDataOutputStream.hflush() (called from OrcRecordUpdater}} which is available on HDFS but is often implemented as no-op in Blob store backed FileSystem objects. Need to add a check to HiveStreamingConnection() constructor to raise an error if builder.transactionBatchSize > 1 and the target table/partitions are backed by something that doesn't support hflush(). Diffs ----- streaming/src/java/org/apache/hive/streaming/HiveStreamingConnection.java f4e71f915b streaming/src/test/org/apache/hive/streaming/TestStreaming.java 055672f910 Diff: https://reviews.apache.org/r/71760/diff/1/ Testing ------- Based on a previous precommit test, only affected tests are: TestCompactor,TestStreaming Thanks, Dávid Lavati