Re: Review Request 71988: HIVE-22703: Compaction configuration check when starting HMS/HS2

2020-01-15 Thread Laszlo Pinter via Review Board
> On Jan. 13, 2020, 2:37 p.m., Denys Kuzmenko wrote: > > service/src/java/org/apache/hive/service/server/HiveServer2.java > > Lines 437 (patched) > > > > > > do we have constant for "hs2" literal? For "hs2" no,

Re: Review Request 71988: HIVE-22703: Compaction configuration check when starting HMS/HS2

2020-01-15 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71988/#review219268 --- Ship it! Ship It! - Denys Kuzmenko On Jan. 13, 2020, 2:12

Re: Review Request 71988: HIVE-22703: Compaction configuration check when starting HMS/HS2

2020-01-13 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71988/#review219237 --- LGTM, just minor comments

Review Request 71988: HIVE-22703: Compaction configuration check when starting HMS/HS2

2020-01-13 Thread Laszlo Pinter via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71988/ --- Review request for hive, Denys Kuzmenko, Karen Coppage, and Peter Vary.