Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

2020-06-03 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72465/#review220950 --- Ship it! Ship It! - Denys Kuzmenko On May 20, 2020, 12:24

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

2020-06-03 Thread Denys Kuzmenko via Review Board
> On May 18, 2020, 7:33 a.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnStatus.java > > Lines 32 (patched) > > > > > > Could you please

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

2020-06-03 Thread Denys Kuzmenko via Review Board
- Denys --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72465/#review220802 --- On May 20, 2020, 12:24 p.m., Peter Varga wrote: > >

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

2020-05-20 Thread Peter Varga via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72465/ --- (Updated May 20, 2020, 12:24 p.m.) Review request for hive and Denys Kuzmenko.

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

2020-05-20 Thread Peter Varga via Review Board
> On May 18, 2020, 7:33 a.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnStatus.java > > Lines 32 (patched) > > > > > > Could you please

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

2020-05-18 Thread Denys Kuzmenko via Review Board
> On May 18, 2020, 7:33 a.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnStatus.java > > Lines 32 (patched) > > > > > > Could you please

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

2020-05-18 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72465/#review220802 --- Thank you for the patch, Peter! LGTM 1 comment on static import

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

2020-05-07 Thread Peter Varga via Review Board
> On May 4, 2020, 3 p.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java > > Line 107 (original), 110 (patched) > > > > > >

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

2020-05-07 Thread Peter Varga via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72465/ --- (Updated May 7, 2020, 11:58 a.m.) Review request for hive and Denys Kuzmenko.

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

2020-05-06 Thread Denys Kuzmenko via Review Board
> On May 4, 2020, 3 p.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnUtils.java > > Lines 400 (patched) > > > > > > Is is a generic txn

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

2020-05-05 Thread Peter Varga via Review Board
> On May 4, 2020, 3 p.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnUtils.java > > Lines 400 (patched) > > > > > > Is is a generic txn

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

2020-05-04 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72465/#review220593 ---

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

2020-05-04 Thread Peter Varga via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72465/ --- (Updated May 4, 2020, 1:22 p.m.) Review request for hive and Denys Kuzmenko.

Review Request 72465: HIVE-23340 TxnHandler cleanup

2020-05-04 Thread Peter Varga via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72465/ --- Review request for hive and Denys Kuzmenko. Repository: hive-git Description