Re: Review Request 72469: HIVE-23325: Clean up cleanup tasks for TxnHandler/CompactionTxnHandler

2020-05-06 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72469/#review220657 --- Ship it! Ship It! - Denys Kuzmenko On May 5, 2020, 7:42 a.m.

Re: Review Request 72469: HIVE-23325: Clean up cleanup tasks for TxnHandler/CompactionTxnHandler

2020-05-05 Thread Marton Bod
> On May 4, 2020, 3:21 p.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/AcidCompactionHistoryService.java > > Line 31 (original), 32 (patched) > > >

Re: Review Request 72469: HIVE-23325: Clean up cleanup tasks for TxnHandler/CompactionTxnHandler

2020-05-05 Thread Marton Bod
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72469/ --- (Updated May 5, 2020, 7:42 a.m.) Review request for hive, Denys Kuzmenko and Pe

Re: Review Request 72469: HIVE-23325: Clean up cleanup tasks for TxnHandler/CompactionTxnHandler

2020-05-04 Thread Denys Kuzmenko via Review Board
> On May 4, 2020, 3:21 p.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/AcidCompactionHistoryService.java > > Line 31 (original), 32 (patched) > > >

Re: Review Request 72469: HIVE-23325: Clean up cleanup tasks for TxnHandler/CompactionTxnHandler

2020-05-04 Thread Marton Bod
> On May 4, 2020, 3:21 p.m., Denys Kuzmenko wrote: > > LGTM , just few questions Thanks for the review! > On May 4, 2020, 3:21 p.m., Denys Kuzmenko wrote: > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java > > Line 153 (original) > >

Re: Review Request 72469: HIVE-23325: Clean up cleanup tasks for TxnHandler/CompactionTxnHandler

2020-05-04 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72469/#review220594 --- LGTM , just few questions ql/src/java/org/apache/hadoop/hive/ql/

Review Request 72469: HIVE-23325: Clean up cleanup tasks for TxnHandler/CompactionTxnHandler

2020-05-04 Thread Marton Bod
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72469/ --- Review request for hive, Denys Kuzmenko and Peter Vary. Repository: hive-git