Re: Review Request 72472: HIVE-23318: TxnHandler need not delete from MATERIALIZATION_REBUILD_LOCKS on need basis

2020-05-06 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72472/#review220656 --- Ship it! Ship It! - Denys Kuzmenko On May 5, 2020, 8:58

Re: Review Request 72472: HIVE-23318: TxnHandler need not delete from MATERIALIZATION_REBUILD_LOCKS on need basis

2020-05-06 Thread Marton Bod
> On May 6, 2020, 11:18 a.m., Denys Kuzmenko wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java > > Line 3158 (original) > > > > > > nit: new line added it back > On May 6, 2020, 11:18 a.m.,

Re: Review Request 72472: HIVE-23318: TxnHandler need not delete from MATERIALIZATION_REBUILD_LOCKS on need basis

2020-05-06 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72472/#review220652 --- LGTM, minor comments

Re: Review Request 72472: HIVE-23318: TxnHandler need not delete from MATERIALIZATION_REBUILD_LOCKS on need basis

2020-05-06 Thread Denys Kuzmenko via Review Board
> On May 6, 2020, 4:54 a.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java > > Line 3153 (original), 3153 (patched) > > > > > > Unrelated to this patch but related to

Re: Review Request 72472: HIVE-23318: TxnHandler need not delete from MATERIALIZATION_REBUILD_LOCKS on need basis

2020-05-06 Thread Denys Kuzmenko via Review Board
> On May 6, 2020, 4:54 a.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java > > Line 3153 (original), 3153 (patched) > > > > > > Unrelated to this patch but related to

Re: Review Request 72472: HIVE-23318: TxnHandler need not delete from MATERIALIZATION_REBUILD_LOCKS on need basis

2020-05-06 Thread Marton Bod
> On May 6, 2020, 4:54 a.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java > > Line 3153 (original), 3153 (patched) > > > > > > Unrelated to this patch but related to

Re: Review Request 72472: HIVE-23318: TxnHandler need not delete from MATERIALIZATION_REBUILD_LOCKS on need basis

2020-05-05 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72472/#review220647 --- ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java Line

Review Request 72472: HIVE-23318: TxnHandler need not delete from MATERIALIZATION_REBUILD_LOCKS on need basis

2020-05-05 Thread Marton Bod
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72472/ --- Review request for hive, Denys Kuzmenko and Peter Vary. Repository: hive-git