Re: Review request for HIVE-22983

2020-03-27 Thread Zoltan Haindrich
Hey Zhihua! I think it's good as is :) Next time if you would like someone to review your changes; the usual routine is to mention someone on the jira. You could look for "reviewer candidates" by: * annotating some of the changed files; and take a look at commit date/what kind of change was it

Review request for HIVE-22983

2020-03-27 Thread dengzhhu653
Hi all A small fix on comments of ConstantPropagate, Can someone help review this the code changes or give feedback on it? https://issues.apache.org/jira/browse/HIVE-22983 Thanks Zhihua