on the output of the
template generation and update the templates to get rid of the issues. E.g.
}while
- Eric Hanson
On May 16, 2013, 6:47 p.m., tony murphy wrote:
---
This is an automatically generated e-mail. To reply, visit
.
Please run ant checkstyle.
Overall the style looks good though!
- Eric Hanson
On May 17, 2013, 2:36 p.m., Teddy Choi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11222
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11133/#review20739
---
Ship it!
Ship It!
- Eric Hanson
On May 17, 2013, 6:06 p.m
/TestVectorStringExpressions.java
https://reviews.apache.org/r/11106/#comment42988
explain
- Eric Hanson
On May 21, 2013, 5:56 p.m., Timothy Chen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11106
the comments inline.
- Eric Hanson
On May 21, 2013, 12:14 p.m., Teddy Choi wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11222
/exec/vector/expressions/TestVectorArithmeticExpressions.java
42872b2
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorScalarColArithmetic.java
a58f837
Diff: https://reviews.apache.org/r/11385/diff/
Testing
---
Thanks,
Eric Hanson
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11106/#review21097
---
Ship it!
Ship It!
- Eric Hanson
On May 22, 2013, 1:19 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11222/#review21099
---
Ship it!
Ship It!
- Eric Hanson
On May 28, 2013, 1:10 a.m
] == true
But you are checking for the value of isNull[I] for in in the assert
which is a bit misleading.
Maybe test against true in the else branch?
- Eric Hanson
On May 29, 2013, 11:36 p.m., Gopal V wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11530/#review21261
---
Ship it!
Ship It!
- Eric Hanson
On May 31, 2013, 1:59 p.m
, l_shipmode)
from lineitem_orc
where l_orderkey = 1;
select l_shipmode, concat(lower(l_shipmode), upper(lower(l_shipmode)))
from lineitem_orc
where l_orderkey = 1;
Thanks,
Eric Hanson
ad-hoc end-to end tests with a variety of UDFs.
Thanks,
Eric Hanson
e-mail. To reply, visit:
https://reviews.apache.org/r/14113/#review26071
---
On Sept. 12, 2013, 11:57 p.m., Eric Hanson wrote:
---
This is an automatically generated e-mail
---
Also did extensive ad-hoc end-to end tests with a variety of UDFs.
Thanks,
Eric Hanson
/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizedRowBatch.java
PRE-CREATION
Diff: https://reviews.apache.org/r/10592/diff/
Testing
---
Thanks,
Eric Hanson
---
Thanks,
Eric Hanson
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10592/#review19350
---
On April 18, 2013, 1:27 a.m., Eric Hanson wrote:
---
This is an automatically
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java
PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizedRowBatch.java
PRE-CREATION
Diff: https://reviews.apache.org/r/10592/diff/
Testing
---
Thanks,
Eric Hanson
/10706/diff/
Testing
---
Thanks,
Eric Hanson
it would not
make sense for it to be another type -- the method name even says Batch
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedORCReader.java
https://reviews.apache.org/r/10712/#comment40488
should add another test with some null values
- Eric Hanson
On April 22, 2013
(about 30%
time savings for filters and arithmetic)
- Eric Hanson
On April 24, 2013, 9:53 p.m., Sarvesh Sakalanaga wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10712
PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorStringExpressions.java
fe34b11
Diff: https://reviews.apache.org/r/10785/diff/
Testing
---
Thanks,
Eric Hanson
/expressions/templates/CodeGen.java
32c7e11
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/FilterStringColumnCompareScalar.txt
PRE-CREATION
Diff: https://reviews.apache.org/r/10785/diff/
Testing
---
Thanks,
Eric Hanson
---
Thanks,
Eric Hanson
/hadoop/hive/ql/exec/vector/expressions/templates/FilterStringColumnCompareScalar.txt
PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorStringExpressions.java
fe34b11
Diff: https://reviews.apache.org/r/10840/diff/
Testing
---
Thanks,
Eric Hanson
/StringConcatScalarCol.java
PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorStringExpressions.java
c0e71e5
Diff: https://reviews.apache.org/r/10868/diff/
Testing
---
Thanks,
Eric Hanson
/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/ColumnArithmeticColumn.txt
f76cb4b
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorArithmeticExpressions.java
a918ad6
Diff: https://reviews.apache.org/r/10874/diff/
Testing
---
Thanks,
Eric
/exec/vector/expressions/TestVectorArithmeticExpressions.java
a918ad6
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorStringExpressions.java
c0e71e5
Diff: https://reviews.apache.org/r/10868/diff/
Testing
---
Thanks,
Eric Hanson
/exec/vector/expressions/TestVectorStringExpressions.java
c0e71e5
Diff: https://reviews.apache.org/r/10868/diff/
Testing
---
Thanks,
Eric Hanson
/10906/diff/
Testing
---
Thanks,
Eric Hanson
9279101
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorScalarColArithmetic.java
7c8b9c3
Diff: https://reviews.apache.org/r/10911/diff/
Testing
---
Thanks,
Eric Hanson
/TestVectorStringExpressions.java
6371d66
Diff: https://reviews.apache.org/r/10978/diff/
Testing
---
Thanks,
Eric Hanson
besides 0 are always set to not null. The
isNull entries for them could have been true by chance from a previous use of
the batch
- Eric Hanson
On May 13, 2013, 9:54 p.m., Timothy Chen wrote:
---
This is an automatically generated e
/TestColumnColumnFilterVectorExpressionEvaluation.java
https://reviews.apache.org/r/11133/#comment42353
Why not just used VectorizedRowBatch.DEFAULT_SIZE? is there a reason?
- Eric Hanson
On May 14, 2013, 12:34 a.m., tony murphy wrote:
---
This is an automatically generated e
they are right.
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorStringExpressions.java
https://reviews.apache.org/r/11106/#comment42453
some lines are longer than 100 char limit. Run ant checkstyle on this.
- Eric Hanson
On May 15, 2013, 1:16 a.m., Timothy Chen wrote
-CREATION
ql/src/test/results/clientpositive/vectorized_string_funcs.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/14664/diff/
Testing
---
Thanks,
Eric Hanson
/r/14576/#comment53213
All the getBytes() calls should be getBytes(UTF-8).
It may actually matter for the multiByte char cases.
- Eric Hanson
On Oct. 21, 2013, 6 p.m., Jitendra Pandey wrote:
---
This is an automatically
/vector/TestVectorizationContext.java
90ab983
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorFilterExpressions.java
3687c46
Diff: https://reviews.apache.org/r/14920/diff/
Testing
---
Unit tests and end-to-end tests.
Thanks,
Eric Hanson
/TestVectorFilterExpressions.java
24da692
Diff: https://reviews.apache.org/r/15149/diff/
Testing
---
See HIVE-5583 for a description of tests done.
Thanks,
Eric Hanson
/TestVectorizationContext.java
6afaf1b
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorFilterExpressions.java
24da692
Diff: https://reviews.apache.org/r/15251/diff/
Testing
---
Thanks,
Eric Hanson
of stylistic comments. Could you also add a
page or so of design description to the design document for vectorized query
execution attached to HIVE-4160? Thanks Remus. -Eric
- Eric Hanson
On Oct. 12, 2013, 9:51 p.m., Remus Rusanu wrote
/
Testing
---
Thanks,
Eric Hanson
Diff: https://reviews.apache.org/r/15495/diff/
Testing
---
Thanks,
Eric Hanson
: https://reviews.apache.org/r/15495/diff/
Testing
---
Thanks,
Eric Hanson
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15594/#review28989
---
Ship it!
Ship It!
- Eric Hanson
On Nov. 15, 2013, 9:33 p.m
/15561/#comment56077
Please add a comment before the method
- Eric Hanson
On Nov. 15, 2013, 1:57 a.m., Ted Xu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15561
/file_with_header_footer.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/15663/diff/
Testing
---
Thanks,
Eric Hanson
/test/queries/clientpositive/file_with_header_footer.q PRE-CREATION
ql/src/test/results/clientpositive/file_with_header_footer.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/15663/diff/
Testing
---
Thanks,
Eric Hanson
/#comment56226
Please run checkstyle. E.g. there should be a blank between ){
- Eric Hanson
On Nov. 19, 2013, 1:31 a.m., Eric Hanson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15663
/queries/clientpositive/vectorization_div0.q
https://reviews.apache.org/r/15869/#comment56810
COALESCE does not vectorize yet
- Eric Hanson
On Nov. 27, 2013, 2:20 a.m., Sergey Shelukhin wrote:
---
This is an automatically generated e
still. Did you upload latest diff to ReviewBoard?
- Eric Hanson
On Nov. 27, 2013, 2:20 a.m., Sergey Shelukhin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15869
/TestVectorScalarColArithmetic.java
https://reviews.apache.org/r/15869/#comment57122
need to assert out.noNulls is false after evaluate. Otherwise, isNull array
contents are undefined.
- Eric Hanson
On Dec. 3, 2013, 9:44 p.m., Sergey Shelukhin wrote
On Nov. 27, 2013, 7:02 p.m., Eric Hanson wrote:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongColumn.java,
line 101
https://reviews.apache.org/r/15869/diff/1/?file=391380#file391380line101
I think the output will be always all nulls in this case
: https://reviews.apache.org/r/15495/diff/
Testing
---
Thanks,
Eric Hanson
-CREATION
Diff: https://reviews.apache.org/r/15495/diff/
Testing
---
Thanks,
Eric Hanson
://reviews.apache.org/r/15495/diff/
Testing
---
Thanks,
Eric Hanson
,
Eric Hanson
ql/src/test/org/apache/hadoop/hive/ql/optimizer/physical/TestVectorizer.java
https://reviews.apache.org/r/16167/#comment58023
Please comment the tests to explain what you are checking
- Eric Hanson
On Dec. 11, 2013, 7:26 a.m., Remus Rusanu wrote
/apache/hadoop/hive/ql/exec/vector/expressions/NullUtil.java
https://reviews.apache.org/r/16269/#comment58257
Again, NaN is only for double, not long
- Eric Hanson
On Dec. 14, 2013, 1:38 a.m., Sergey Shelukhin wrote
. Please use full
sentences and proper punctuation (start with capital letter, end with period).
- Eric Hanson
On Dec. 11, 2013, 9:19 p.m., Shuaishuai Nie wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
://reviews.apache.org/r/16307/diff/
Testing
---
Thanks,
Eric Hanson
-CREATION
common/src/test/org/apache/hadoop/hive/common/type/TestUnsignedInt128.java
PRE-CREATION
Diff: https://reviews.apache.org/r/16307/diff/
Testing
---
Thanks,
Eric Hanson
common/src/test/org/apache/hadoop/hive/common/type/TestUnsignedInt128.java
PRE-CREATION
Diff: https://reviews.apache.org/r/16307/diff/
Testing
---
Thanks,
Eric Hanson
/src/test/org/apache/hadoop/hive/common/type/TestUnsignedInt128.java
PRE-CREATION
Diff: https://reviews.apache.org/r/16307/diff/
Testing
---
Thanks,
Eric Hanson
/browse/HIVE-6546
Repository: hive-git
Description
---
See JIRA
Diffs
-
hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/JobSubmissionConstants.java
482e993
Diff: https://reviews.apache.org/r/18816/diff/
Testing
---
Thanks,
Eric Hanson
5, 2014, 9:39 p.m.)
Review request for hive and Eric Hanson.
Bugs: HIVE-6511
https://issues.apache.org/jira/browse/HIVE-6511
Repository: hive-git
Description
---
Casting from decimal to tinyint,smallint, int and bigint generates different
result when vectorization
7, 2014, 4:39 a.m.)
Review request for hive and Eric Hanson.
Bugs: HIVE-6511
https://issues.apache.org/jira/browse/HIVE-6511
Repository: hive-git
Description
---
Casting from decimal to tinyint,smallint, int and bigint generates different
result when vectorization
/apache/hadoop/hive/ql/exec/vector/expressions/CastDecimalToTimestamp.java
https://reviews.apache.org/r/18972/#comment67784
Please comment why you're using this logic.
- Eric Hanson
On March 10, 2014, 5:02 p.m., Jitendra Pandey wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18972/#review36803
---
Ship it!
Ship It!
- Eric Hanson
On March 10, 2014, 9:51 p.m
://reviews.apache.org/r/19140/diff/
Testing
---
Thanks,
Eric Hanson
https://reviews.apache.org/r/19218/#comment68694
it'd be good to remove trailing white space
- Eric Hanson
On March 14, 2014, 9:06 a.m., Jitendra Pandey wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19216/#review37296
---
Ship it!
Ship It!
- Eric Hanson
On March 14, 2014, 8:41 a.m
for DecimalColumnInList
- Eric Hanson
On March 27, 2014, 7:02 a.m., Jitendra Pandey wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19718
/TestVectorizationContext.java
https://reviews.apache.org/r/19718/#comment71331
Again, why string and not long not between operator?
- Eric Hanson
On March 28, 2014, 9:56 p.m., Jitendra Pandey wrote:
---
This is an automatically generated e-mail. To reply
/TestVectorizedORCReader.java
https://reviews.apache.org/r/16760/#comment59956
Minor nit -- hive coding standards say put blanks around operator symbols
(%) and blank lines before comments.
- Eric Hanson
On Jan. 9, 2014, 9:01 p.m., Jitendra Pandey wrote
sometimes, not each individual object.
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedORCReader.java
https://reviews.apache.org/r/17005/#comment61051
do you want to include the printing in the final test?
- Eric Hanson
On Jan. 17, 2014, 12:58 a.m., Jitendra Pandey wrote
make the value NULL if that is the case, and maybe
log an error.
- Eric Hanson
On Jan. 24, 2014, 10:28 p.m., Jitendra Pandey wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17005
are conditionally changing the
scale.
- Eric Hanson
On Jan. 27, 2014, 11:20 p.m., Jitendra Pandey wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17005
/hadoop/hive/ql/optimizer/physical/Vectorizer.java
https://reviews.apache.org/r/17622/#comment62885
Please add a comment why you are using decimal.* and why it's different
than the others.
- Eric Hanson
On Jan. 31, 2014, 10:19 p.m., Jitendra Pandey wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17622/#review33747
---
Ship it!
Ship It!
- Eric Hanson
On Jan. 31, 2014, 10:19 p.m
a
test.
ql/src/test/results/clientpositive/vectorization_short_regress.q.out
https://reviews.apache.org/r/17769/#comment63837
It looks like some new rows showed up in the output after you changed the
test. Is this expected, or does it reveal a correctness issue?
- Eric Hanson
On Feb. 7
/VectorizationContext.java
https://reviews.apache.org/r/17769/#comment64060
Please add comment before method explaining what it does.
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java
https://reviews.apache.org/r/17769/#comment64059
loose - lose
- Eric Hanson
On Feb. 8, 2014
/expressions/VectorCoalesce.java
https://reviews.apache.org/r/18025/#comment64398
What happens if one of the inputs is a scalar, not a column?
ql/src/test/queries/clientpositive/vector_coalesce.q
https://reviews.apache.org/r/18025/#comment64399
ERIC TODO: start reviewing here
- Eric Hanson
this:
COALESCE(col1, ..., colK, 0)
So if arguments 1..K are NULL, the default value is the constant at the
end, 0 in this case. Could you please make that work in this patch, or open a
separate JIRA to do it later?
- Eric Hanson
On Feb. 12, 2014, 7 p.m., Jitendra Pandey wrote
/#comment65148
please remove trailing white space in .q file (several locations)
- Eric Hanson
On Feb. 17, 2014, 9:05 a.m., Jitendra Pandey wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
, or if this code is
already covered by other tests, please explain in comments on the JIRA.
common/src/java/org/apache/hadoop/hive/common/type/SqlMathUtil.java
https://reviews.apache.org/r/18566/#comment66370
Please add comment saying the purpose of this method
- Eric Hanson
On Feb. 27
[
https://issues.apache.org/jira/browse/HIVE-4472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13659757#comment-13659757
]
Eric Hanson commented on HIVE-4472:
---
I posted additional comments to review board. Patch
[
https://issues.apache.org/jira/browse/HIVE-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13661029#comment-13661029
]
Eric Hanson commented on HIVE-4575:
---
I'm not sure I understand the problem here. Can you
[
https://issues.apache.org/jira/browse/HIVE-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13661083#comment-13661083
]
Eric Hanson commented on HIVE-4575:
---
I did the following in SQL Server:
create table t
[
https://issues.apache.org/jira/browse/HIVE-4548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13661144#comment-13661144
]
Eric Hanson commented on HIVE-4548:
---
Posted review. Looks good overall! Needs a few small
[
https://issues.apache.org/jira/browse/HIVE-4553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13661150#comment-13661150
]
Eric Hanson commented on HIVE-4553:
---
This looks good! Thanks Tony. I think it's ready
[
https://issues.apache.org/jira/browse/HIVE-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13661160#comment-13661160
]
Eric Hanson commented on HIVE-4534:
---
Please put final patch on review board
[
https://issues.apache.org/jira/browse/HIVE-4495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13663551#comment-13663551
]
Eric Hanson commented on HIVE-4495:
---
The latest patch appears functionally correct
[
https://issues.apache.org/jira/browse/HIVE-4548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13663607#comment-13663607
]
Eric Hanson commented on HIVE-4548:
---
See my comments on Review Board. It looks good but I
[
https://issues.apache.org/jira/browse/HIVE-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13664321#comment-13664321
]
Eric Hanson commented on HIVE-4579:
---
Consider adding Column IN (list-of-constants
[
https://issues.apache.org/jira/browse/HIVE-4548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13664336#comment-13664336
]
Eric Hanson commented on HIVE-4548:
---
Can you confirm if there is a problem or not? E.g
[
https://issues.apache.org/jira/browse/HIVE-4548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13664572#comment-13664572
]
Eric Hanson commented on HIVE-4548:
---
It appears that all the specific characters you
Eric Hanson created HIVE-4592:
-
Summary: ColumnArithmeticColumn.txt template never sets output
isNull to true; can give wrong results
Key: HIVE-4592
URL: https://issues.apache.org/jira/browse/HIVE-4592
[
https://issues.apache.org/jira/browse/HIVE-4592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13664761#comment-13664761
]
Eric Hanson commented on HIVE-4592:
---
Found some other issues in null propagation as well
[
https://issues.apache.org/jira/browse/HIVE-4592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HIVE-4592 started by Eric Hanson.
ColumnArithmeticColumn.txt template never sets output isNull to true; can
give wrong results
1 - 100 of 869 matches
Mail list logo
