://reviews.apache.org/r/67368/diff/3/
Changes: https://reviews.apache.org/r/67368/diff/2-3/
Testing
---
Thanks,
Sergey Shelukhin
---
Thanks,
Sergey Shelukhin
://reviews.apache.org/r/67368/diff/2/
Changes: https://reviews.apache.org/r/67368/diff/1-2/
Testing
---
Thanks,
Sergey Shelukhin
,
Sergey Shelukhin
/
Testing
---
Thanks,
Sergey Shelukhin
Was some change made w/versions?
RROR] Plugin org.apache.maven.plugins:maven-clean-plugin:2.5 or one of its
dependencies could not be resolved: Failed to read artifact descriptor for
org.apache.maven.plugins:maven-clean-plugin:jar:2.5: Could not transfer
artifact
Might be related to
https://stackoverflow.com/questions/50946420/could-not-transfer-artifact-ht
tps-repo-maven-apache-org-maven2-received-fat, similar issue in
https://blog.gradle.org/unable-to-download-maven-central-bintray
On 18/6/26, 11:51, "Sergey Shelukhin" wrote:
>Was some
ps://reviews.apache.org/r/67712/#review205443
-------
On June 23, 2018, 12:29 a.m., Sergey Shelukhin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67712/
> -
/DummyRawStoreForJdoConnection.java
d6a882e8e9
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/VerifyingObjectStore.java
c9a6a471cb
Diff: https://reviews.apache.org/r/67712/diff/2/
Changes: https://reviews.apache.org/r/67712/diff/1-2/
Testing
---
Thanks,
Sergey Shelukhin
d6a882e8e98f92eefbdb7900bdf43e3274a21c5d
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/VerifyingObjectStore.java
c9a6a471cb7fc28845efb6d774601dba0cef2a85
Diff: https://reviews.apache.org/r/67712/diff/1/
Testing
---
Thanks,
Sergey Shelukhin
I see this in HiveQA runs:
Could not transfer artifact org.glassfish:javax.el:pom:3.0.1-b06-SNAPSHOT
from/to jvnet-nexus-snapshots
(https://maven.java.net/content/repositories/snapshots): Failed to
transfer file:
https://maven.java.net/content/repositories/snapshots/org/glassfish/javax.e
---
Thanks,
Sergey Shelukhin
Given the constant cluster with HiveQA, namely queue constantly losing or
not picking up patches for whatever reason (not limited to dedup - I uploaded
some patches today where there’s only one attached to the JIRA and still it
didn’t get in the queue or got removed) I wonder if we should
/
Testing
---
Thanks,
Sergey Shelukhin
che/hadoop/hive/ql/TxnCommandsBaseForTests.java
> a2adb966fe
> ql/src/test/queries/clientpositive/mm_exim.q c47342bd23
> ql/src/test/results/clientpositive/llap/mm_exim.q.out 1f40754373
>
>
> Diff: https://reviews.apache.org/r/66720/diff/3/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
fields, a patch file and jira number? That way the
tracking at least can be improved. And the patch choice to run or not run.
This would take less time than trying to appease the fickle spirits of HiveQA
as it is now. And also probably result in somewhat shorter queues.
From: Sergey Shelukhin <
standalone-metastore/src/main/resources/package.jdo 296e273ec8
standalone-metastore/src/main/thrift/hive_metastore.thrift 1d455463a6
Diff: https://reviews.apache.org/r/63346/diff/1/
Testing
---
Thanks,
Sergey Shelukhin
file=1867965#file1867965line1463>
> >
> > is this a recoverable state. If not should session be set to null here?
no, not recoverable... also if state is invalid master thread cannot handle it.
It probably means someone added an enum constant.
- Sergey
---
://reviews.apache.org/r/63230/diff/3/
Changes: https://reviews.apache.org/r/63230/diff/2-3/
Testing
---
Thanks,
Sergey Shelukhin
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63346/#review189384
-------
On Oct. 27, 2017, 12:48 a.m., Sergey Shelukhin wrote:
>
> -
/63346/diff/2/
Changes: https://reviews.apache.org/r/63346/diff/1-2/
Testing
---
Thanks,
Sergey Shelukhin
://reviews.apache.org/r/63230/diff/4/
Changes: https://reviews.apache.org/r/63230/diff/3-4/
Testing
---
Thanks,
Sergey Shelukhin
ery usage is
added in the followup jira
- Sergey
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63230/#review189450
-------
/hadoop/hive/ql/exec/tez/monitoring/QueryExecutionBreakdownSummary.java
271e3c6eeb
Diff: https://reviews.apache.org/r/64965/diff/1/
Testing
---
Thanks,
Sergey Shelukhin
: https://reviews.apache.org/r/64942/diff/2/
Changes: https://reviews.apache.org/r/64942/diff/1-2/
Testing
---
Thanks,
Sergey Shelukhin
/64787/diff/3/
Changes: https://reviews.apache.org/r/64787/diff/2-3/
Testing
---
Thanks,
Sergey Shelukhin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64903/#review194816
---
On Jan. 3, 2018, 2:32 a.m., Sergey Shelukhin wrote:
>
> --
reply, visit:
https://reviews.apache.org/r/64903/#review194821
-------
On Jan. 3, 2018, 2:32 a.m., Sergey Shelukhin wrote:
>
> ---
> This is an automatically generated e-ma
://reviews.apache.org/r/64903/diff/1-2/
Testing
---
Thanks,
Sergey Shelukhin
/ThriftCLIServiceClient.java
d43f1254c5
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMMapping.java
ec0ac3f148
standalone-metastore/src/main/resources/package.jdo e3ae67d58e
Diff: https://reviews.apache.org/r/64999/diff/1/
Testing
---
Thanks,
Sergey
/UserPoolMapping.java
Lines 37 (patched)
<https://reviews.apache.org/r/64999/#comment274000>
the comment needs to be removed
- Sergey Shelukhin
On Jan. 5, 2018, 11:51 p.m., Sergey Shelukhin wrote:
>
> ---
> This is an automatically g
4057 (original), 4062 (patched)
<https://reviews.apache.org/r/65002/#comment274010>
hm, will take a look at this next week
- Sergey Shelukhin
On Jan. 6, 2018, 3:25 a.m., Sergey Shelukhin wrote:
>
> ---
> This is a
/clientpositive/resourceplan.q ce684ed51b
ql/src/test/results/clientpositive/llap/resourceplan.q.out 29c01a8b43
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
5bfa62485b
Diff: https://reviews.apache.org/r/65002/diff/1/
Testing
---
Thanks,
Sergey
,
Sergey Shelukhin
/
Testing
---
Thanks,
Sergey Shelukhin
/2/
Changes: https://reviews.apache.org/r/65002/diff/1-2/
Testing
---
Thanks,
Sergey Shelukhin
/HiveSplitGenerator.java
Lines 226 (patched)
<https://reviews.apache.org/r/63382/#comment274904>
nit: given that this keeps the files in the set anyway, it can increment
the counter once with the size of the set, in the end
- Sergey Shelukhin
On Jan. 17, 2018, 7:38 p.m., Prasanth_J
/clientpositive/resourceplan.q b46c1ee2d6
ql/src/test/results/clientpositive/llap/resourceplan.q.out 72a78b1b4a
Diff: https://reviews.apache.org/r/65185/diff/2/
Changes: https://reviews.apache.org/r/65185/diff/1-2/
Testing
---
Thanks,
Sergey Shelukhin
ps://reviews.apache.org/r/65185/#review195530
-------
On Jan. 17, 2018, 2:15 a.m., Sergey Shelukhin wrote:
>
> ---
> This is an automatically generated e-mail.
od to have an option to disable it
- Sergey
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65148/#review195504
-------
On Jan
://reviews.apache.org/r/65185/diff/1/
Testing
---
Thanks,
Sergey Shelukhin
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
6aa5d95a8a
Diff: https://reviews.apache.org/r/65206/diff/1/
Testing
---
Thanks,
Sergey Shelukhin
/
Testing
---
Thanks,
Sergey Shelukhin
/diff/1-2/
Testing
---
Thanks,
Sergey Shelukhin
/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/Reader.java df536ead1c
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/ReaderImpl.java
203ef69cf6
Diff: https://reviews.apache.org/r/65148/diff/1/
Testing
---
Thanks,
Sergey Shelukhin
/EncodedReaderImpl.java
627e617d91
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/Reader.java df536ead1c
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/ReaderImpl.java
203ef69cf6
Diff: https://reviews.apache.org/r/65148/diff/1/
Testing
---
Thanks,
Sergey Shelukhin
/diff/2-3/
Testing
---
Thanks,
Sergey Shelukhin
gt; 1Gb, not for any one vertex.
- Sergey Shelukhin
On Jan. 11, 2018, 10:17 p.m., Prasanth_J wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
c6a866a1644f087d260f78e280d07867d81cbc0c
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java
65508f4ddd66140a273c8c447c0ee93f4f139454
Diff: https://reviews.apache.org/r/65413/diff/1/
Testing
---
Thanks,
Sergey Shelukhin
/
Testing
---
Thanks,
Sergey Shelukhin
: https://reviews.apache.org/r/65356/diff/3/
Changes: https://reviews.apache.org/r/65356/diff/2-3/
Testing
---
Thanks,
Sergey Shelukhin
/65415/diff/1-2/
Testing
---
Thanks,
Sergey Shelukhin
: https://reviews.apache.org/r/65356/diff/2/
Changes: https://reviews.apache.org/r/65356/diff/1-2/
Testing
---
Thanks,
Sergey Shelukhin
.
Repository: hive-git
Description
---
see jira
Diffs
-
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 23983d85b3
Diff: https://reviews.apache.org/r/65425/diff/1/
Testing
---
Thanks,
Sergey Shelukhin
as I can tell every call to this method, passes null for
> > isBaseDir. Can this be removed?
>
> Sergey Shelukhin wrote:
> Nm, it was supposed to be passed in one place where available.
>
> Eugene Koifman wrote:
> i don't understand this. are you saying there is
---
Thanks,
Sergey Shelukhin
uld be trace
- Sergey Shelukhin
On Jan. 30, 2018, 3:19 a.m., Sergey Shelukhin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
ly, visit:
https://reviews.apache.org/r/65356/#review196437
-------
On Jan. 26, 2018, 9:03 p.m., Sergey Shelukhin wrote:
>
> ---
> This is an automatically generated e-mail.
/65413/diff/2-3/
Testing
---
Thanks,
Sergey Shelukhin
understand this should
also be skipped for insert-only tables
- Sergey
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65413/#review196819
ive_metastore.thrift
Line 331 (original), 333 (patched)
<https://reviews.apache.org/r/65130/#comment276706>
what does expertMode actually mean? ie what does it affect. Perhaps there
should be a comment in Table.java that explains it.
-
matically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65413/#review196904
---
On Feb. 6, 2018, 3:29 a.m., Sergey Shelukhin wrote:
>
> ---
> This is an auto
/TestVectorizedOrcAcidRowBatchReader.java
65508f4ddd
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/LockComponentBuilder.java
de6c718ba9
Diff: https://reviews.apache.org/r/65413/diff/4/
Changes: https://reviews.apache.org/r/65413/diff/3-4/
Testing
---
Thanks,
Sergey Shelukhin
://reviews.apache.org/r/65579/diff/1/
Testing
---
Thanks,
Sergey Shelukhin
65508f4ddd
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/LockComponentBuilder.java
de6c718ba9
Diff: https://reviews.apache.org/r/65413/diff/5/
Changes: https://reviews.apache.org/r/65413/diff/4-5/
Testing
---
Thanks,
Sergey Shelukhin
stupid RB won't let me edit my own comment...
> > Previsouly this check was testing for full acid but now just for
> > transactional. Why?
>
> Sergey Shelukhin wrote:
> It's used to skip global limit optimization. As far as I understand this
> should also be skip
> This seems to change the logic. isAcidTable() used to mean full acid,
> > but now it less than that...
>
> Sergey Shelukhin wrote:
> Responded on IM :)
>
> Eugene Koifman wrote:
> I don't see it in IM. Why is this done?
>
> Eugene Koifman wrote:
>
> > Below, you left the same compBuilder.setIsAcid(isFullAcid) but here it
> > using isTransactional - why the logical change?
>
> Sergey Shelukhin wrote:
> fixed; this affects whether locks are taken so my understanding is it's
> also needed for MM
>
> Eugene Koifman
/AcidUtils.java 553e8bcf4e
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 2152f00028
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java
236e585dc8
Diff: https://reviews.apache.org/r/65622/diff/1/
Testing
---
Thanks,
Sergey Shelukhin
65508f4ddd
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/LockComponentBuilder.java
de6c718ba9
Diff: https://reviews.apache.org/r/65413/diff/6/
Changes: https://reviews.apache.org/r/65413/diff/5-6/
Testing
---
Thanks,
Sergey Shelukhin
/ImportSemanticAnalyzer.java
70f5e21937
ql/src/test/queries/clientpositive/mm_exim.q 8a03f4d463
ql/src/test/results/clientpositive/llap/mm_exim.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/65596/diff/1/
Testing
---
Thanks,
Sergey Shelukhin
/resourceplan.q.out b23720d1a8
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
dad2d356cb
Diff: https://reviews.apache.org/r/65579/diff/2/
Changes: https://reviews.apache.org/r/65579/diff/1-2/
Testing
---
Thanks,
Sergey Shelukhin
is only happens
during sysdb init
- Sergey
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65579/#review197150
-------
On Feb
> > Below, you left the same compBuilder.setIsAcid(isFullAcid) but here it
> > using isTransactional - why the logical change?
>
> Sergey Shelukhin wrote:
> fixed; this affects whether locks are taken so my understanding is it's
> also needed for MM
>
> Eugene Koifman
/java/org/apache/hadoop/hive/ql/metadata/Hive.java
eefa8f756cdcb7d56ed5ff46f4f0bcbfd170a0cf
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java
5deec4b0f96682dae9b5558ac26060d845044984
Diff: https://reviews.apache.org/r/65663/diff/1/
Testing
---
Thanks,
Sergey
ion where I left an open item. I am not sure how
that comment applies :)
- Sergey
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65663/#review197837
---------
eefa8f756c
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java
5deec4b0f9
Diff: https://reviews.apache.org/r/65663/diff/3/
Changes: https://reviews.apache.org/r/65663/diff/2-3/
Testing
---
Thanks,
Sergey Shelukhin
I think the primary motivation for cache was the cloud use-case where the
default SQL instance is underpowered and you have to set up and pay more
to get a performant one. The same may apply to setting up redis/memcached
on the cloud environment - if you set one up you might as well just get
the
ch do not belong to the
table data set.
- Sergey
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65415/#review196696
-------
://reviews.apache.org/r/65415/diff/3/
Changes: https://reviews.apache.org/r/65415/diff/2-3/
Testing
---
Thanks,
Sergey Shelukhin
/VectorizedRowBatch.java
Lines 227 (patched)
<https://reviews.apache.org/r/65766/#comment278267>
should be removed; same for most below changes
- Sergey Shelukhin
On Feb. 23, 2018, 4:34 a.m., Sergey Shelukhin
/exec/vector/VectorizedRowBatch.java
bebf7691f7
Diff: https://reviews.apache.org/r/65766/diff/1/
Testing
---
Thanks,
Sergey Shelukhin
and it's easier to add it here then to trace all
possible paths these calls can take.
- Sergey
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65663/#review197625
---
On Feb. 15, 2018, 1:28 a.m.,
Do we have HiveQA set up for branch-2?
I noticed that tests were not run on HIVE-18710-branch-2.patch; they have
run for me in the past on the similarly named branch-2 patches.
,
Sergey Shelukhin
4b0a1ceca4
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/Consumer.java 43c56472f3
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java
29cef30d5f
Diff: https://reviews.apache.org/r/64903/diff/1/
Testing
---
Thanks,
Sergey Shelukhin
/r/64787/diff/2/
Changes: https://reviews.apache.org/r/64787/diff/1-2/
Testing
---
Thanks,
Sergey Shelukhin
,
Sergey Shelukhin
/
Testing
---
Thanks,
Sergey Shelukhin
Congrats!
On 18/7/30, 12:53, "Gunther Hagleitner"
wrote:
>Congratulations!
>
>Thanks,
>Gunther.
>
>From: Xuefu Zhang
>Sent: Monday, July 30, 2018 12:11 PM
>To: dev@hive.apache.org
>Subject: Re: [ANNOUNCE] New committer: Slim Bouguerra
>
/diff/1/
Testing
---
Thanks,
Sergey Shelukhin
---
Thanks,
Sergey Shelukhin
---
.
Diffs
-
llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java
fcfc22a712
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java
348f9df773
Diff: https://reviews.apache.org/r/68072/diff/1/
Testing
---
Thanks,
Sergey Shelukhin
---
Thanks,
Sergey Shelukhin
/
Changes: https://reviews.apache.org/r/68072/diff/1-2/
Testing
---
Thanks,
Sergey Shelukhin
/apache/hive/service/cli/session/TestSessionManagerMetrics.java
d954692e98
Diff: https://reviews.apache.org/r/68034/diff/3/
Changes: https://reviews.apache.org/r/68034/diff/2-3/
Testing
---
Thanks,
Sergey Shelukhin
Could this be related to some tests running in parallel?
https://builds.apache.org/job/PreCommit-HIVE-Build/13209/testReport/org.apa
che.hive.jdbc/TestActivePassiveHA/testManualFailoverUnauthorized/
2018-08-14T04:11:45,837 ERROR [Thread-10] server.HiveServer2: Error
starting Web UI:
/acid_stats4.q.out afd5adb4ff
Diff: https://reviews.apache.org/r/68434/diff/1/
Testing
---
Thanks,
Sergey Shelukhin
I think it’s very simple conceptually (well the way I’ve been thinking
about it), and any limitations can be derived from this using logic. If
someone has specific questions we can clarify; if some limitations are
missing (e.g. when Hive was using stats for hbase tables) it is a bug.
For managed
,
Sergey Shelukhin
1001 - 1100 of 4123 matches
Mail list logo
