[jira] [Commented] (HIVE-4844) Add varchar data type

2013-09-15 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767724#comment-13767724 ] Hive QA commented on HIVE-4844: --- {color:green}Overall{color}: +1 all checks pass Here are

[jira] [Commented] (HIVE-4844) Add varchar data type

2013-09-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767919#comment-13767919 ] Hudson commented on HIVE-4844: -- FAILURE: Integrated in Hive-trunk-hadoop2 #431 (See

[jira] [Commented] (HIVE-4844) Add varchar data type

2013-09-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767936#comment-13767936 ] Hudson commented on HIVE-4844: -- FAILURE: Integrated in Hive-trunk-hadoop2-ptest #98 (See

[jira] [Commented] (HIVE-4844) Add varchar data type

2013-09-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767937#comment-13767937 ] Hudson commented on HIVE-4844: -- FAILURE: Integrated in Hive-trunk-hadoop1-ptest #165 (See

[jira] [Commented] (HIVE-4844) Add varchar data type

2013-09-14 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767433#comment-13767433 ] Hive QA commented on HIVE-4844: --- {color:green}Overall{color}: +1 all checks pass Here are

[jira] [Commented] (HIVE-4844) Add varchar data type

2013-09-14 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767534#comment-13767534 ] Hive QA commented on HIVE-4844: --- {color:green}Overall{color}: +1 all checks pass Here are

[jira] [Commented] (HIVE-4844) Add varchar data type

2013-09-14 Thread Jason Dere (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767548#comment-13767548 ] Jason Dere commented on HIVE-4844: -- Just got the unit test results from v18 and one of the

[jira] [Commented] (HIVE-4844) Add varchar data type

2013-09-13 Thread Ashutosh Chauhan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13766095#comment-13766095 ] Ashutosh Chauhan commented on HIVE-4844: +1 Add varchar data type

[jira] [Commented] (HIVE-4844) Add varchar data type

2013-09-13 Thread Phabricator (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13766149#comment-13766149 ] Phabricator commented on HIVE-4844: --- ashutoshc has commented on the revision HIVE-4844

[jira] [Commented] (HIVE-4844) Add varchar data type

2013-09-13 Thread Ashutosh Chauhan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13765858#comment-13765858 ] Ashutosh Chauhan commented on HIVE-4844: [~jdere] Left some comments on

[jira] [Commented] (HIVE-4844) Add varchar data type

2013-09-13 Thread Phabricator (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13766216#comment-13766216 ] Phabricator commented on HIVE-4844: --- jdere has commented on the revision HIVE-4844 [jira]

[jira] [Commented] (HIVE-4844) Add varchar data type

2013-09-13 Thread Phabricator (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13766271#comment-13766271 ] Phabricator commented on HIVE-4844: --- ashutoshc has accepted the revision HIVE-4844 [jira]

[jira] [Commented] (HIVE-4844) Add varchar data type

2013-09-13 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767064#comment-13767064 ] Xuefu Zhang commented on HIVE-4844: --- Thanks for making so much progress in such a short

[jira] [Commented] (HIVE-4844) Add varchar data type

2013-09-13 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767104#comment-13767104 ] Xuefu Zhang commented on HIVE-4844: --- Also in ParseUtils.getCharParams(), checking

[jira] [Commented] (HIVE-4844) Add varchar data type

2013-09-12 Thread Ashutosh Chauhan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13765866#comment-13765866 ] Ashutosh Chauhan commented on HIVE-4844: And few more : ) Add

[jira] [Commented] (HIVE-4844) Add varchar data type

2013-09-11 Thread Jason Dere (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13764989#comment-13764989 ] Jason Dere commented on HIVE-4844: -- Sure, I'll bump the max down to 65535, though it won't

[jira] [Commented] (HIVE-4844) Add varchar data type

2013-09-10 Thread Jason Dere (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13763739#comment-13763739 ] Jason Dere commented on HIVE-4844: -- Ok, 64K sounds good then. As it turns out there was

[jira] [Commented] (HIVE-4844) Add varchar data type

2013-09-10 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13763958#comment-13763958 ] Xuefu Zhang commented on HIVE-4844: --- Yeah. 64K is good. Just minor thought. Instead of

[jira] [Commented] (HIVE-4844) Add varchar data type

2013-09-09 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13762007#comment-13762007 ] Xuefu Zhang commented on HIVE-4844: --- I think people use varchar in Hive probably because

[jira] [Commented] (HIVE-4844) Add varchar data type

2013-09-06 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760721#comment-13760721 ] Xuefu Zhang commented on HIVE-4844: --- [~jdere] Looking at your latest patch, I'm wondering

[jira] [Commented] (HIVE-4844) Add varchar data type

2013-09-06 Thread Jason Dere (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760823#comment-13760823 ] Jason Dere commented on HIVE-4844: -- The max varchar length setting was pretty arbitrary,

[jira] [Commented] (HIVE-4844) Add varchar data type

2013-08-30 Thread Jason Dere (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13755136#comment-13755136 ] Jason Dere commented on HIVE-4844: -- All three failures mentioned above

[jira] [Commented] (HIVE-4844) Add varchar data type

2013-08-30 Thread Jason Dere (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13755294#comment-13755294 ] Jason Dere commented on HIVE-4844: -- ashutoshc, like Xuefu, has suggested that this patch