[PATCH] headers not sent when subrequests come from ap_die

2001-11-11 Thread sterling
Hi - I have run across a situation where the header filters are not inserted (when using ErrorDocument). Back in the day we added the add_required_filters call to ap_die to handle the scenario where the request cycle didn't quite get to the insert_filters phase. Problem is we add those filters

Re: Something I learned, today

2001-11-11 Thread William A. Rowe, Jr.
From: "Brian Pane" <[EMAIL PROTECTED]> Sent: Saturday, November 10, 2001 1:21 AM > William A. Rowe, Jr. wrote: > > >If one adds a module multiple times, (in this case, the silly user just > >commented out the ClearModuleList) there is no warning whatsoever, yet > >it causes (obviously) no end o

Re: ap_cgi_var_lookup()

2001-11-11 Thread William A. Rowe, Jr.
++1 on concept - this has irked me for some time now. mod_isapi, mod_includes and a ton of other modules query a given variable, not the entire list... so this idea makes much good sense :) Didn't have the brainpower/bandwidth to absorb the actual patch this weekend, but I'm looking forward to

Re: ap_cgi_var_lookup()

2001-11-11 Thread sterling
Sweet - that ssl_var_lookup needs something exactly like this. I say you do the same for that. sterling On Sat, 10 Nov 2001, Doug MacEachern wrote: > i would like to avoid calling ap_add_{common,cgi}_vars() in mod_perl and > just tie Perl's %ENV to a lookup function. i cooked up some generat

[PATCH] headers not sent when subrequests come from ap_die (fwd)

2001-11-11 Thread sterling
I'm forwarding this on cuz 2 days later it still hasn't shown up. sterling -- Forwarded message -- Date: Fri, 9 Nov 2001 17:27:50 -0800 (PST) From: sterling <[EMAIL PROTECTED]> To: [EMAIL PROTECTED] Subject: [PATCH] headers not sent when subrequests come from ap_die Hi - I hav

Re: [PATCH] Make apr_table_elts const

2001-11-11 Thread Justin Erenkrantz
On Sat, Nov 10, 2001 at 04:46:00PM -0800, Brian Pane wrote: > All the current uses of apr_table_elts in Apache 2.0 are for > const iterators, so the only change required to the httpd code > is the replacement of "apr_array_header_t*" declarations with > "const apr_array_header_t*" (the patch inclu