Re: [PATCH] don't accept more connections than idle workers

2002-04-27 Thread Aaron Bannert
On Fri, Apr 26, 2002 at 07:36:45PM -0700, Justin Erenkrantz wrote: Fine, if that's your argument. (And, I've been thinking of doing this before.) So, we should switch apr_pcalloc to fix this rather than avoid the problem. If we fix the problem, all of the code magically gets optimized

RE: [PATCH] don't accept more connections than idle workers

2002-04-27 Thread Sander Striker
From: Aaron Bannert [mailto:[EMAIL PROTECTED]] Sent: 27 April 2002 09:34 On Fri, Apr 26, 2002 at 07:36:45PM -0700, Justin Erenkrantz wrote: Fine, if that's your argument. (And, I've been thinking of doing this before.) So, we should switch apr_pcalloc to fix this rather than avoid

RE: [PATCH] don't accept more connections than idle workers

2002-04-27 Thread Cliff Woolley
On Sat, 27 Apr 2002, Sander Striker wrote: http://www.mail-archive.com/dev@httpd.apache.org/msg02492.html The performance prob goes away when we make apr_pcalloc into a macro. Based on your comments, I'm assuming that's a +1 from Sander and Justin, making three so far. Aaron, I'm guessing

[PATCH] apxs.in

2002-04-27 Thread Pier Fumagalli
This is (again) Thom's patch to make APXS work when we don't use standard layouts, and we move things around after building... It works great on Darwin, if someone could possibly check that out and review, that would be absolutely fantastic... Pier -- I think that it's extremely foolish to

Re: Atomics in general

2002-04-27 Thread David Reid
I'm more in favour of diabled by default and a switch to enable. If 2.0.36 does look good then binaries will be required (given we have binaries for .35) and I'd rather we avoided too many issues. 2.0.37 won't be far away and maybe we'll have fixed it by then. david - Original Message

[FINDINGS/PATCH] --enable-shared=moduleA moduleB not working onDarwin...

2002-04-27 Thread Pier Fumagalli
context file=STATUS * --enable-mods-shared=foo1 foo2 is busted on Darwin. Pier posted a patch (Message-ID: [EMAIL PROTECTED]). /context Naya... Doesn't work -AT-ALL-... It looks like a bug in /bin/sh which on Darwin is ZSH or some major misunderstanding between that and autoconf.

Re: cvs commit: httpd-2.0/server/mpm/worker worker.c fdqueue.c fdqueue.h

2002-04-27 Thread Justin Erenkrantz
Comments inline. On Sun, Apr 28, 2002 at 01:45:00AM -, [EMAIL PROTECTED] wrote: 1.16 +108 -0httpd-2.0/server/mpm/worker/fdqueue.c Index: fdqueue.c === RCS file:

More worker ideas Re: cvs commit: httpd-2.0/server/mpm/workerworker.c fdqueue.c fdqueue.h

2002-04-27 Thread Brian Pane
[EMAIL PROTECTED] wrote: aaron 02/04/27 18:45:00 Modified:server/mpm/worker worker.c fdqueue.c fdqueue.h Log: Add a queue_info structure to the worker MPM. This is used to prevent the listener thread from accept()ing more connections than there are available workers. This

Re: cvs commit: httpd-2.0/server/mpm/worker worker.c fdqueue.c fdqueue.h

2002-04-27 Thread Aaron Bannert
On Sat, Apr 27, 2002 at 07:30:51PM -0700, Justin Erenkrantz wrote: +qi = apr_palloc(pool, sizeof(*qi)); +memset(qi, 0, sizeof(*qi)); As we said, if you are concerned about the performance aspect of apr_pcalloc, then we should fix apr_pcalloc NOT attempt to work around its

Re: More worker ideas Re: cvs commit: httpd-2.0/server/mpm/worker worker.c fdqueue.c fdqueue.h

2002-04-27 Thread Aaron Bannert
On Sat, Apr 27, 2002 at 07:39:24PM -0700, Brian Pane wrote: I was going to complain about the addition of yet another mutex to the critical path of request processing, but it got me thinking about an approach to making worker faster: shorten the time spent in the mutex-protected region. Yes!

Content-Length problem

2002-04-27 Thread Brian Havard
In current HEAD (and the 2.0.36 tag) I'm seeing an incorrect Content-Length: header in the case where: - The request is for a directory index - Config has: DirectoryIndex index.shtml index.html - The requested directory has an index.shtml - The index.shtml contains an #include virtual The

Re: Content-Length problem

2002-04-27 Thread Justin Erenkrantz
On Sun, Apr 28, 2002 at 02:21:52PM +1000, Brian Havard wrote: In current HEAD (and the 2.0.36 tag) I'm seeing an incorrect Content-Length: header in the case where: - The request is for a directory index - Config has: DirectoryIndex index.shtml index.html - The requested directory has an

Re: cvs commit: httpd-2.0/server/mpm/worker fdqueue.c

2002-04-27 Thread Justin Erenkrantz
On Sun, Apr 28, 2002 at 03:32:10AM -, [EMAIL PROTECTED] wrote: brianp 02/04/27 20:32:10 Modified:server/mpm/worker fdqueue.c Log: Move a potentially expensive pool cleanup operation outside the mutex-protected critical path of ap_queue_pop() Revision Changes