RE: SSL upgrade [was: Final patch for a long time]

2002-12-11 Thread Sander Striker
> From: William A. Rowe, Jr. [mailto:[EMAIL PROTECTED]] > Sent: Thursday, December 12, 2002 8:08 AM > At 11:46 AM 10/15/2002, [EMAIL PROTECTED] wrote: > [snip] > >The second is SSL upgrade. I have the patches, they haven't been > >committed yet. I have attached them at the bottom of this message

SSL upgrade [was: Final patch for a long time]

2002-12-11 Thread William A. Rowe, Jr.
At 11:46 AM 10/15/2002, [EMAIL PROTECTED] wrote: [snip] >The second is SSL upgrade. I have the patches, they haven't been >committed yet. I have attached them at the bottom of this message. The >reason they haven't been committed, is that I don't have a client to test >them with, and I haven't h

[STATUS] (httpd-2.0) Wed Dec 11 23:45:19 EST 2002

2002-12-11 Thread Rodent of Unusual Size
APACHE 2.1 STATUS: -*-text-*- Last modified at [$Date: 2002/12/03 18:26:44 $] Release [NOTE that only Alpha/Beta releases occur in 2.1 development]: 2.1.0 : in development Please consult the following STATUS files for information on related proj

[STATUS] (apache-1.3) Wed Dec 11 23:45:11 EST 2002

2002-12-11 Thread Rodent of Unusual Size
APACHE 1.3 STATUS: -*-text-*- Last modified at [$Date: 2002/10/31 05:57:52 $] Release: 1.3.28-dev: In development 1.3.27: Tagged September 30, 2002. Announced Oct 3, 2002. 1.3.26: Tagged June 18, 2002. 1.3.25: Tagged June 17, 2002. Not re

Re: [PATCH] Have logfiles closed on exec

2002-12-11 Thread Martin Kraemer
> Here it is: > > Index: src/CHANGES > > + *) Certain 3rd party modules would bypass [...] Perhaps you could improve my blurb. It was not written very intelligently For the rest: * the patch as mailed did not apply cleanly here (some tab expansion glitches, but only whitespace diffs, bu

Re: cvs commit: httpd-2.0/server protocol.c

2002-12-11 Thread Greg Ames
Brian Pane wrote: +1 for the patch in 2.0.44. Longer term, a better solution might be able to fix the problem closer to its source. I'm assuming, based on the code, that the problem only occurs when the "folding" logic in ap_get_mime_headers_core is invoked. That's the only case I see where the

Re: [PATCH] Have logfiles closed on exec

2002-12-11 Thread Jim Jagielski
At 6:05 PM +0100 12/11/02, Martin Kraemer wrote: > >I gotta hurry back home now to see the kids - dunno yet when I'll have >time. Feel free to do it - (and: adding php to the server makes for >the easiest test bed for the leaking). > Here it is: Index: src/CHANGES

Re: [PATCH] Have logfiles closed on exec

2002-12-11 Thread Martin Kraemer
On Wed, Dec 11, 2002 at 12:00:12PM -0500, Jim Jagielski wrote: > > Looks good! +1 on the ap_psocket_ex(), which should be minor to do. > Let me know if you have time to do it; if not, I'll fold it in to > the big patch. I gotta hurry back home now to see the kids - dunno yet when I'll have time.

Re: [PATCH] Have logfiles closed on exec

2002-12-11 Thread Martin Kraemer
On Wed, Dec 11, 2002 at 11:49:43AM -0500, Jim Jagielski wrote: > > Should the default behavior of ap_popenf be to perform the > magic cleanup then? We already do so with ap_open_piped_log(). As I said: inside Apache, there's no reason not to change it. But I don't know how many 3rd party modules

Re: [PATCH] Have logfiles closed on exec

2002-12-11 Thread Jim Jagielski
At 5:21 PM +0100 12/11/02, Martin Kraemer wrote: > Martin >PS: I append the combined patch of your changes and mine, but without >the new ap_psocket_ex(). TBD Looks good! +1 on the ap_psocket_ex(), which should be minor to do. Let me know if you have time to do it; if not, I'll fold it in to the

Re: [PATCH] Have logfiles closed on exec

2002-12-11 Thread Jim Jagielski
Martin Kraemer wrote: > > > In contrast to the patch in my previous reply (which called > ap_note_cleanups_for_fd_ex() for *ALL* occurrences of ap_popenf()), > we now have more open fd's in PHP again. The fd's of the fcntl() lock > files are (created by ap_popenf() and) not closed. > So, there's

Re: FW: cvs commit: httpd-2.0/modules/proxy proxy_http.c

2002-12-11 Thread Brian Pane
Unless I'm missing something, this patch would make the proxy vulnerable to a DoS. An attacker could cause the httpd to buffer an arbitrarily large amount of data simply by sending an arbitrarily large request body, right? Brian On Tue, 2002-12-10 at 15:55, Bill Stoddard wrote: > Any objections

Re: [PATCH-3] Allowing extended characters in LDAP authentication...

2002-12-11 Thread André Malo
* Brad Nicholes wrote: > This patch eliminates the hardcoded charset table. Instead it reads the > charset table from a conf file. The directive AuthLDAPCharsetConfig allows > the admin to specify the charset conf file. You should change the command error messages... ;-) > Is there also a need

Re: [PATCH] Have logfiles closed on exec

2002-12-11 Thread Martin Kraemer
On Wed, Dec 11, 2002 at 09:25:19AM -0500, Jim Jagielski wrote: > This patch uses the recently folded in "magic" cleanups to > have all log files (well, access and transfer logs) set with > CLOSEXEC. It also adds another *_ex function (ap_popenf_ex) > and allows for the magic cleanups to be called/r

RE: FW: cvs commit: httpd-2.0/modules/proxy proxy_http.c

2002-12-11 Thread Bill Stoddard
> "Bill Stoddard" <[EMAIL PROTECTED]> writes: > > > Any objections to porting this to 2.0? > > > > Bill > > > > jerenkrantz2002/12/08 21:37:27 > > > > Modified:.CHANGES > >modules/proxy proxy_http.c > > Log: > > Rewrite how proxy sends its request to allow

Re: [PATCH] Have logfiles closed on exec

2002-12-11 Thread Martin Kraemer
On Wed, Dec 11, 2002 at 09:25:19AM -0500, Jim Jagielski wrote: > > Comments?? What a coincidence. I was just about to post this mail: ---snip-- Hi, This patch takes Jim's ap_note_cleanups_for_*_ex() functions and plugs the open fd's being passed to children of, say, PHP. With this patch, I teste

[PATCH] Have logfiles closed on exec

2002-12-11 Thread Jim Jagielski
This patch uses the recently folded in "magic" cleanups to have all log files (well, access and transfer logs) set with CLOSEXEC. It also adds another *_ex function (ap_popenf_ex) and allows for the magic cleanups to be called/run whenever by passing a NULL pool (also protects against dumps when a

Re: FW: cvs commit: httpd-2.0/modules/proxy proxy_http.c

2002-12-11 Thread Paul J. Reder
Jeff Trawick wrote: "Bill Stoddard" <[EMAIL PROTECTED]> writes: Any objections to porting this to 2.0? Bill jerenkrantz2002/12/08 21:37:27 Modified:.CHANGES modules/proxy proxy_http.c Log: Rewrite how proxy sends its request to allow input bodies to morph

Re: FW: cvs commit: httpd-2.0/modules/proxy proxy_http.c

2002-12-11 Thread Jeff Trawick
"Bill Stoddard" <[EMAIL PROTECTED]> writes: > Any objections to porting this to 2.0? > > Bill > > jerenkrantz2002/12/08 21:37:27 > > Modified:.CHANGES >modules/proxy proxy_http.c > Log: > Rewrite how proxy sends its request to allow input bodies to morph th

Re: g++ warnings

2002-12-11 Thread Giorgos Keramidas
On 2002-12-11 00:49, "Philip M. Gollucci" <[EMAIL PROTECTED]> wrote: > /usr/include/sys/syslimits.h:41:2: warning: #warning "No > user-serviceable parts inside." Userlevel applications should not include this file. There's nothing left in that file that they should depend upon. The applications