Re: [PATCH] mod_proxy hangs on 304 from backend

2004-01-08 Thread Bill Stoddard
Richard Reiner wrote: mod_proxy hangs when both KeepAlive and ProxyErrorOverride are enabled, and a non-200 response without a body is generated by the backend server. Commited to 2.1 and called a vote to backport to 2.0. Thanks, Bill

Re: cvs commit: httpd-2.0/modules/experimental mod_mem_cache.c

2004-01-08 Thread Bill Stoddard
Jean-Jacques Clar wrote: Bill, The patch you committed is only for 21285. My bet for 21287 (no mutex lock protection in decrement_refcount). from the bug description: "/There are no mutex lock protection in decrement_refcount if it is defined USE_ATOMICS. I think you simply forgot the mutex in

[PATCH] mod_proxy hangs on 304 from backend

2004-01-08 Thread Richard Reiner
mod_proxy hangs when both KeepAlive and ProxyErrorOverride are enabled, and a non-200 response without a body is generated by the backend server. (e.g.: a client makes a request containing the "If-Modified-Since" and "If-None-Match" headers, to which the backend server respond with status 304.

Re: cvs commit: httpd-2.0/modules/experimental mod_mem_cache.c

2004-01-08 Thread Jean-Jacques Clar
Bill,   The patch you committed is only for 21285.   My bet for 21287 (no mutex lock protection in decrement_refcount). from the bug description: "There are no mutex lock protection in decrement_refcount if it isdefined USE_ATOMICS.I think you simply forgot the mutex in function decrement_refcou

Re: log_error_core escaping change broke things

2004-01-08 Thread Stas Bekman
Geoffrey Young wrote: Stas, we have closed a well known and remotely exploitable security leak. This goes straight over comfort. If you don't like it, provide an alternative solution. Just nagging or trying to talk the problem away doesn't help. is creating a compile-time flag to disable the new-de

FNM_PERIOD, etc...

2004-01-08 Thread Jim Jagielski
We're being sloppy with these... Shouldn't all FNM_* in httpd be using the APR versions? Just grepping for FNM_PERIOD... ./modules/generators/mod_autoindex.c: FNM_NOESCAPE | FNM_PERIOD) ./modules/generators/mod_autoindex.c: FNM_NOESCAP

Crash - Win32 on restart

2004-01-08 Thread Aryeh Katz
I have a win32 apache (with a whole bunch of modules loaded) that crashes on restart. I think the scenario to replicate is: 1) start as service 2) modify conf file (with typo) 3) restart 4) modify conf file (fix typo) 5) restart 6) restart The call stack I'm getting (main->ap_run_post_config->mi

ap_custom_response() problem

2004-01-08 Thread Indraneel Sarkar
Version: 2.0.48 In our module, we are using ap_custom_response() to set response data based on certain header value from the user-agent. The logic is as follows: module_check_user_id(request_rec *r) { // // ... // if (our_agent_detected && need_to_fail_authn) { ap_

what about 2.1.0 ?????

2004-01-08 Thread Günter Knauf
Hi all, now we have already tagged for two times, tested, and nothing happened - no 2.1.0 release is out yet. What's about a new third try with a following release this time??? I really wish we could have 2.1 out so that the users get a version number they can refer to; that makes bug reports

Re: cvs commit: httpd-2.0/modules/experimental mod_mem_cache.c

2004-01-08 Thread Bill Stoddard
Here is the patch that fill fix the problem reported by 21287 http://cvs.apache.org/viewcvs.cgi/httpd-2.0/modules/experimental/mod_mem_cache.c?r1=1.99&r2=1.100 Bill Hi Jean-Jacques, What specific problem is this patch correcting? I committed a fix for 21287 prior to the holidays. The idea behind

Re: cvs commit: httpd-2.0/modules/experimental mod_mem_cache.c

2004-01-08 Thread Bill Stoddard
Hi Jean-Jacques, What specific problem is this patch correcting? I committed a fix for 21287 prior to the holidays. The idea behind using atomic operators on refcount is to avoid the need to acquire the mutex when incrementing/decrementing refcount. Bill [EMAIL PROTECTED] wrote: clar20

Re: [PATCH] raise MAX_SERVER_LIMIT

2004-01-08 Thread Bill Stoddard
Colm MacCarthaigh wrote: Not entirely serious, but today, we actually hit this, in production :) The hardware, a dual 2Ghz Xeon with 12Gb RAM with Linux 2.6.1-rc2 coped, and remained responsive. So 20,000 may no longer be outside the realms of what administrators reasonably desire to have. Index: s

Re: [dav-dev] [PATCH] PR#21779 Fix

2004-01-08 Thread Joe Orton
On Thu, Jan 01, 2004 at 09:43:03AM +, amit athavale wrote: > Hi, > > Attached is the patch for fix of PR#21779. > > I am not sure whether I have added that code at best/ideal place, so > please review it and let me know if there is another place where I can > put that check. Thanks Amit, I

About mod_auth_ldap and openldap

2004-01-08 Thread A. H. W. Kong
Hi, all, I am using httpd-2.0.48 with openldap-2.0.27. I have defined a directive as such: Dav on AuthType Indexes AuthType Basic AuthName DAV AuthLDAPURL "ldap://192.168.0.25"; require valid-user A minor problem I found is : if I used double-qoute around DAV in the AuthN