Re: [PATCH-Modified-2] SSL not sending close alert message

2004-02-26 Thread Joe Orton
On Wed, Feb 25, 2004 at 05:12:33PM -0800, Mathihalli, Madhusudan wrote: > More feedback incorporated ! ap_flush_conn can just use a single brigade with two buckets, no extra variables needed there, also needs s/APU_DECLARE/AP_DECLARE in eoc_bucket.c, and perhaps the prototypes are more appropriate

Re: 1.x: byte-range with ErrorDocuments returns incorrect status code

2004-02-26 Thread Geoffrey Young
Will Lowe wrote: > It looks like byte-range requests on non-existant files returns 206 > instead of 404 if ErrorDocument is set. I was able to verify this - it looks like there's some simple logic in 2.0 that wasn't carried over to 1.3. so, try this patch. all the byterange tests in the perl

Re: "(97)Address family not supported by protocol" causes "disk ticking"?

2004-02-26 Thread gregames
Alexis Huxley wrote: [Mon Feb 16 23:35:33 2004] [warn] (97)Address family not supported by protocol: get socket to connect to listener [Mon Feb 16 23:35:34 2004] [warn] (97)Address family not supported by protocol: get socket to connect to listener Ok, it did it again. Here's the

RE: finish connection hook (WAS: RE: [PATCH] SSL not sending close alert message)

2004-02-26 Thread Justin Erenkrantz
--On Wednesday, February 25, 2004 1:20 PM -0800 "Mathihalli, Madhusudan" <[EMAIL PROTECTED]> wrote: Hooking the cleanups to the connection pool may be a little too late for some modules (Example SSL shutdown/SSL Alert). For filters like SSL, the EOC logic would probably be just fine - I can't thi

Re: [PATCH-Modified-2] SSL not sending close alert message

2004-02-26 Thread Justin Erenkrantz
--On Thursday, February 26, 2004 11:58 AM + Joe Orton <[EMAIL PROTECTED]> wrote: On Wed, Feb 25, 2004 at 05:12:33PM -0800, Mathihalli, Madhusudan wrote: More feedback incorporated ! ap_flush_conn can just use a single brigade with two buckets, no extra variables needed there, also needs s/APU

Error in rcs file in httpd-2.0 CVS repository

2004-02-26 Thread Brian. W. Fitzpatrick
I'm in the process of testing out the cvs2svn.py converter, and the converter found an inconsistency in the httpd-2.0 repository. The file /httpd-2.0/docs/manual/misc/Attic/known_client_problems.html,v Contains APACHE_1_2_X:1.3; which is a tag at rev 1.3, while all other rcs declarations of th

RE: Error in rcs file in httpd-2.0 CVS repository

2004-02-26 Thread Sander Striker
> From: Brian. W. Fitzpatrick [mailto:[EMAIL PROTECTED] > Sent: Thursday, February 26, 2004 5:53 PM > I'm in the process of testing out the cvs2svn.py converter, and the > converter found an inconsistency in the httpd-2.0 repository. > > The file > /httpd-2.0/docs/manual/misc/Attic/known_client_

RE: Error in rcs file in httpd-2.0 CVS repository

2004-02-26 Thread Brian. W. Fitzpatrick
On Thu, 2004-02-26 at 11:17, Sander Striker wrote: > > From: Brian. W. Fitzpatrick [mailto:[EMAIL PROTECTED] > > Sent: Thursday, February 26, 2004 5:53 PM > > > I'm in the process of testing out the cvs2svn.py converter, and the > > converter found an inconsistency in the httpd-2.0 repository. > >

RE: [PATCH-Modified-2] SSL not sending close alert message

2004-02-26 Thread Mathihalli, Madhusudan
>-Original Message- >From: Joe Orton [mailto:[EMAIL PROTECTED] [SNIP] > >ap_flush_conn can just use a single brigade with two buckets, no extra >variables needed there, Hmmn.. will that not introduce a mem leak ? >also needs s/APU_DECLARE/AP_DECLARE in >eoc_bucket.c, and perhaps the pro

RE: [PATCH-Modified-2] SSL not sending close alert message

2004-02-26 Thread Justin Erenkrantz
--On Thursday, February 26, 2004 10:17 AM -0800 "Mathihalli, Madhusudan" <[EMAIL PROTECTED]> wrote: ap_flush_conn can just use a single brigade with two buckets, no extra variables needed there, Hmmn.. will that not introduce a mem leak ? I don't think so. Why do you think so? -- justin

RE: [PATCH-Modified-2] SSL not sending close alert message

2004-02-26 Thread Mathihalli, Madhusudan
>-Original Message- >From: Justin Erenkrantz [mailto:[EMAIL PROTECTED] [SNIP] >--On Thursday, February 26, 2004 10:17 AM -0800 "Mathihalli, >Madhusudan" ><[EMAIL PROTECTED]> wrote: > >>> ap_flush_conn can just use a single brigade with two >buckets, no extra >>> variables needed there,

RE: [PATCH-Modified-2] SSL not sending close alert message

2004-02-26 Thread Mathihalli, Madhusudan
Sorry - the earlier mail was a result of my mis-understanding Joe's comment. Here's the correct patch. Thanks -Madhu Index: include/http_connection.h === RCS file: /home/cvs/httpd-2.0/include/http_connection.h,v retrieving revision

Re: cvs commit: httpd-2.0/modules/loggers mod_log_config.c

2004-02-26 Thread André Malo
* [EMAIL PROTECTED] wrote: > trawick 2004/02/26 12:00:55 > > Modified:modules/loggers mod_log_config.c > Log: > a kind fix for a compile error unfortunately broke an order > dependency... the buffered logs array needs to be initialized > prior to opening the logs oh? I must ha

Re: cvs commit: httpd-2.0 STATUS

2004-02-26 Thread Jeff Trawick
[EMAIL PROTECTED] wrote: gregames2004/02/26 12:12:13 Modified:.Tag: APACHE_2_0_BRANCH STATUS Log: vote on exception hook backport. review was fine, extra credit for cleaning up the duplication of signal handling between the mpms. Tested on RH9 w/prefork - no regressio

Re: "(97)Address family not supported by protocol" causes "disk ticking"?

2004-02-26 Thread Alexis Huxley
>> Process 1008 attached - interrupt to quit >> select(0, NULL, NULL, NULL, {0, 62}) = 0 (Timeout) >> write(6, "!", 1)= 1 >> socket(PF_INET6, SOCK_STREAM, IPPROTO_IP) = -1 ENOSYS (Function not >> implemented) >> socket(PF_INET6, SOCK_STREAM, IPP

[PATCH] Windows IPv6

2004-02-26 Thread Allan
Here's a patch to enable IPv6 on Windows XP & 2003. In addition we'll need to change the setting of APR_HAVE_IPV6 in apr.hw - seems like we'll need some awk magic to do that. Note that enabling IPv6 drags in the need for the XP or 2003 platform SDK but I don't see any way around it. I believe the p

Re: [PATCH] Windows IPv6

2004-02-26 Thread William A. Rowe, Jr.
+1, but which warning does 4163 quiet? At 09:46 AM 2/26/2004, you wrote: >Here's a patch to enable IPv6 on Windows XP & 2003. >In addition we'll need to change the setting of >APR_HAVE_IPV6 in apr.hw - seems like we'll need >some awk magic to do that. > >Note that enabling IPv6 drags in the need f

Re: "(97)Address family not supported by protocol" causes "disk ticking"?

2004-02-26 Thread William A. Rowe, Jr.
At 03:40 PM 2/25/2004, Alexis Huxley wrote: [Mon Feb 16 23:35:33 2004] [warn] (97)Address family not supported by protocol: get socket to connect to listener the ticking is an unexpected hard flush when APR_APPEND causes win32 to file lock for write. Bill

RE: Error in rcs file in httpd-2.0 CVS repository

2004-02-26 Thread Brian. W. Fitzpatrick
On Thu, 2004-02-26 at 11:17, Sander Striker wrote: > > From: Brian. W. Fitzpatrick [mailto:[EMAIL PROTECTED] > > Sent: Thursday, February 26, 2004 5:53 PM > > > I'm in the process of testing out the cvs2svn.py converter, and the > > converter found an inconsistency in the httpd-2.0 repository. > >

RE: Error in rcs file in httpd-2.0 CVS repository

2004-02-26 Thread Brian. W. Fitzpatrick
On Thu, 2004-02-26 at 11:17, Sander Striker wrote: > > From: Brian. W. Fitzpatrick [mailto:[EMAIL PROTECTED] > > Sent: Thursday, February 26, 2004 5:53 PM > > > I'm in the process of testing out the cvs2svn.py converter, and the > > converter found an inconsistency in the httpd-2.0 repository. > >

RE: Error in rcs file in httpd-2.0 CVS repository

2004-02-26 Thread Sung Kim
On Thu, 2004-02-26 at 11:17, Sander Striker wrote: > From: Brian. W. Fitzpatrick [mailto:[EMAIL PROTECTED] > Sent: Thursday, February 26, 2004 5:53 PM > I'm in the process of testing out the cvs2svn.py converter, and the > converter found an inconsistency in the httpd-2.0 repository. Is that me