Re: Time for 2.0.51 and 2.1.0

2004-08-27 Thread Graham Leggett
Sander Striker wrote: I'm going to start a TR cycle for both 2.0 and 2.1 monday. Objections? With the imminent release of APR v1.0, would it be possible to make the default build of v2.1.0 link to an external install of APR v1.0, instead of including a dedicated apr within the srclib directory

Memory leak!?

2004-08-27 Thread Morten Due Jorgensen
Hi there, I am very sorry, if this is an inappropriate place/manner to post this, but I have tried the users mail list without getting any response, I have searched the bug database with no result, and then I was recommended to try here. I hope you will bare with me, as this is a long post, but I

Re: cvs commit: apache-1.3/src/main http_protocol.c http_request.c

2004-08-27 Thread Roy T . Fielding
This doesn't look right. Checking the notes table is a serious performance hit, and why does it matter how many times keepalives is incremented on an error path? There must be a better way to do this. Roy On Friday, August 27, 2004, at 04:44 PM, [EMAIL PROTECTED] wrote: jim

Re: cvs commit: apache-1.3/src/main http_protocol.c http_request.c

2004-08-27 Thread Rasmus Lerdorf
Yeah, I am not keen on the notes table approach either. My original patch to fix this didn't do that. Not that my patch was great either. The problem with calling ap_set_keepalive() multiple times is that the function doesn't just set the keepalive flag, it also increments the connection's

Re: cvs commit: apache-1.3/src/main http_protocol.c http_request.c

2004-08-27 Thread Rasmus Lerdorf
On Fri, 27 Aug 2004 [EMAIL PROTECTED] wrote: /* + * We need to ensure that r-connection-keepalive is valid in + * order to determine if we can discard the request body below. + */ +ap_set_keepalive(r); I realize you probably just took my wording there, but it