Re: mod_dnsbl_lookup 0.90

2005-08-14 Thread Justin Erenkrantz
On Fri, Jul 29, 2005 at 10:11:46PM +0100, Colm MacCarthaigh wrote: > Cool. I'd split dnsbl_zones into ipv4_dnsbl_zones and ipv6_dnsbl_zones > and have the DnsblZones directive work like; > > DnsblIPv4Zones > DnsblIPv6Zones FWIW, I think it'd be fine to have DnsblZones implicitly be

open_logs hook's ordering

2005-08-14 Thread C.G. Lee
hi~   I can't understand the hook sorting in the case:   I see the modules registering open_logs hook are prefork.c, core.c, log_config.c. When these modules register the hook, they use the order like this.   prefork.c  : APR_HOOK_MIDDLE core.c : APR_HOOK_REALLY_FIRST log_config.c : AP

Re: New mod_smtpd release

2005-08-14 Thread Joe Schaefer
Rian Hunter <[EMAIL PROTECTED]> writes: > You can checkout this code out from: > http://svn.apache.org/repos/asf/httpd/mod_smtpd/trunk/ Very cool, thanks! I had some trouble compiling it, and I noticed you're using // comments alot. Here are two patches for that. diff -pur trunk/.svn/entries tr

Re: New mod_smtpd release

2005-08-14 Thread Branko Čibej
Joe Schaefer wrote: Rian Hunter <[EMAIL PROTECTED]> writes: You can checkout this code out from: http://svn.apache.org/repos/asf/httpd/mod_smtpd/trunk/ Very cool, thanks! I had some trouble compiling it, and I noticed you're using // comments alot. Here are two patches for that.

Re: New mod_smtpd release

2005-08-14 Thread Joe Schaefer
Branko Čibej <[EMAIL PROTECTED]> writes: > May I suggest you resend this patch, using "svn diff" instead of "diff > -pur" to create it? You're diffing the SVN administrative directory... Thanks. Here's another patch to add a skeleton STATUS file, using svn diff this time. Index: STATUS ==

[PATCH] mod_smtpd configure fixes

2005-08-14 Thread Garrett Rooney
On my Ubuntu linux box, the Apache2 apxs is installed as 'apxs2', and the httpd binary is installed in the SBINDIR, not BINDIR, and is not named httpd, so the current configure script can't find it. Here's an updated version that makes two changes, first it lets you specify a full path to the

[PATCH] mod_smtpd function naming

2005-08-14 Thread Garrett Rooney
I noticed that mod_smtpd seems to go to some lengths to avoid messing up the global namespace, prefixing globally visible function names with smtpd_ and so forth, but there seems to be one case where this isn't done, process_smtp_connection_internal. This patch renames it to smtpd_process_conn

mod_smtpd compile problem

2005-08-14 Thread Garrett Rooney
So I'm having a little trouble getting mod_smtpd to compile, once I fixed up the configure script to find apxs and apache correctly, I end up with the following error: $ make /usr/bin/apxs2 -Wc,"-Wall" -o mod_smtpd.la -c smtp_core.c smtp_protocol.c /usr/bin/libtool --silent --mode=compile gcc

Re: [PATCH] Make caching hash more deterministic

2005-08-14 Thread Graham Leggett
Colm MacCarthaigh wrote: Currently; GET / HTTP/1.1 Host: ftp.heanet.ie GET http://ftp.heanet.ie/ HTTP/1.0 GET HTTP://Ftp.Heanet.Ie/ HTTP/1.0 are all mapped to different hashes by mod_cache; despite being the same content, this is an inefficient waste of disk s

Re: 2.1 proxy and keepalives

2005-08-14 Thread Graham Leggett
Akins, Brian wrote: Does this code from 2.1 in apr_proxy_http_request still make sense? Do we not want to attempt to maintain the server connection anyway? Maybe I'm missing some other logic... /* strip connection listed hop-by-hop headers from the request */ /* even though in theory a c

smtpd_request_rec questions

2005-08-14 Thread Garrett Rooney
I was just looking at the smtpd_request_rec in mod_smtpd, and I had a few questions. It seems that extensions and rcpt info is being stored in an apr_hash_t, but it's only being keyed by integer. If you're only going to use ints as keys, it seems like an apr_array_header_t would be more appro

Murky decalrations/types in apreq_param.h

2005-08-14 Thread R. Mattes
It's currently impossible to compile apache modules using libabreq2 with c++ compilers due to some inconsistent types in file apreq_param.h. Here are the error messages: In file included from /usr/include/apreq2/apreq_parser.h:21, from /usr/include/apreq2/apreq_module.h:21,

Re: svn commit: r230592 - in /httpd/httpd/branches/2.0.x: CHANGES STATUS modules/proxy/proxy_http.c

2005-08-14 Thread Jeff Trawick
On 8/6/05, William A. Rowe, Jr. <[EMAIL PROTECTED]> wrote: > At 08:39 PM 8/6/2005, Jeff Trawick wrote: > >On 8/6/05, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > >> Author: wrowe > >> Date: Sat Aug 6 14:29:05 2005 > >> New Revision: 230592 > >> > >> URL: http://svn.apache.org/viewcvs?rev=230592&

Bug report for Apache httpd-1.3 [2005/08/14]

2005-08-14 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Apache httpd-2.0 [2005/08/14]

2005-08-14 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Re: New mod_smtpd release

2005-08-14 Thread Rian Hunter
On Aug 14, 2005, at 1:22 PM, Joe Schaefer wrote: snip... +CURRENT RELEASE NOTES: + + Virtual hosts a'la mod_ftpd don't work. It does work like this: Listen 80 Listen 25 NameVirtualHost *:80 NameVirtualHost *:25 ServerName localhost DocumentRoot htdocs ServerName localhost

Re: mod_smtpd compile problem

2005-08-14 Thread Rian Hunter
On Aug 14, 2005, at 2:05 PM, Garrett Rooney wrote: So I'm having a little trouble getting mod_smtpd to compile, once I fixed up the configure script to find apxs and apache correctly, I end up with the following error: $ make /usr/bin/apxs2 -Wc,"-Wall" -o mod_smtpd.la -c smtp_core.c smt

Re: New mod_smtpd release

2005-08-14 Thread Joe Schaefer
Rian Hunter <[EMAIL PROTECTED]> writes: > On Aug 14, 2005, at 1:22 PM, Joe Schaefer wrote: >> +RELEASE SHOWSTOPPERS: >> + >> + >> + smtp_process_connection_internal should take a "smtp_proto_rec" >> + argument (which is what the current "smtp_request_rec" struct >> + should be renamed to). >>

Re: smtpd_request_rec questions

2005-08-14 Thread Rian Hunter
On Aug 14, 2005, at 4:21 PM, Garrett Rooney wrote: I was just looking at the smtpd_request_rec in mod_smtpd, and I had a few questions. It seems that extensions and rcpt info is being stored in an apr_hash_t, but it's only being keyed by integer. If you're only going to use ints as keys

Re: smtpd_request_rec questions

2005-08-14 Thread Garrett Rooney
Rian Hunter wrote: Ah I didn't even realize the key allocation, I'll fix that. Thanks! The reason I don't use an apr_array_t or similar is that I thought that the number of elements in that type has to be fixed and can't be automatically extended and allocated on the fly, If I'm wrong I can

[PATCH] use arrays in smtpd_request_rec (was Re: smtpd_request_rec questions)

2005-08-14 Thread Garrett Rooney
Garrett Rooney wrote: Rian Hunter wrote: Ah I didn't even realize the key allocation, I'll fix that. Thanks! The reason I don't use an apr_array_t or similar is that I thought that the number of elements in that type has to be fixed and can't be automatically extended and allocated on the

Re: New mod_smtpd release

2005-08-14 Thread Rian Hunter
On Aug 14, 2005, at 8:12 PM, Joe Schaefer wrote: Rian Hunter <[EMAIL PROTECTED]> writes: On Aug 14, 2005, at 1:22 PM, Joe Schaefer wrote: +RELEASE SHOWSTOPPERS: + + + smtp_process_connection_internal should take a "smtp_proto_rec" + argument (which is what the current "smtp_request_rec"

Re: [PATCH] use arrays in smtpd_request_rec (was Re: smtpd_request_rec questions)

2005-08-14 Thread Rian Hunter
This patch looks good but I have some questions. You seem to use the returned pointers from apr_array_push without checking if they are NULL. Even in apr_array_push, apr_palloc is used without checking for NULL even though apr_palloc can definitely return NULL. Because of that, I'm not sure

Re: New mod_smtpd release

2005-08-14 Thread Joe Schaefer
Rian Hunter <[EMAIL PROTECTED]> writes: >> The request_rec slot can be NULL for connection-level filters. >> But I'd create a request_rec sometime before I added an smtp protocol >> filter, which would just do the "."-decoding, similar to how >> http_in deals with TE. >> > > Yeah I agree. I'd be

Re: [PATCH] use arrays in smtpd_request_rec (was Re: smtpd_request_rec questions)

2005-08-14 Thread Garrett Rooney
Rian Hunter wrote: This patch looks good but I have some questions. You seem to use the returned pointers from apr_array_push without checking if they are NULL. Even in apr_array_push, apr_palloc is used without checking for NULL even though apr_palloc can definitely return NULL. Because o

Re: New mod_smtpd release

2005-08-14 Thread Ask Bjørn Hansen
On Aug 12, 2005, at 5:57 PM, Rian Hunter wrote: This version of mod_smtpd is callback based, very similar to Qpsmtpd. Here is a list of all the hooks you can register: That's a beautiful cycle. When I added the plugin/extension/hook system to qpsmtpd way back when I borrowed many concepts

Re: New mod_smtpd release

2005-08-14 Thread Jem Berkes
> Well there's also another problem. RFC 2821 (SMTP) doesn't define a > particular message format for SMTP (in wide use there the RFC 822 and > MIME message formats). I don't think that mod_smtpd should assume a RFC > 822 or MIME message format since its strictly a SMTP module, that's why I agre