Re: Coding style

2006-10-04 Thread Maxime Petazzoni
Hi, * Ruediger Pluem <[EMAIL PROTECTED]> [2006-10-02 23:35:03]: > Ok. Point taken. So I guess the best thing for simple if (...) is > Garrett's proposal (put the function call *before* if in a separate > line). For more complex things like the thing above (provided that > we want to allow this at

Re: Coding style

2006-10-04 Thread Joe Orton
On Mon, Oct 02, 2006 at 05:01:51PM -0700, Roy T. Fielding wrote: > In any case, I prefer the style of C code that more directly reflects > the underlying assembly, even if an optimizing compiler would produce > the same assembler for both. It is just natural to read "use the result > of this save

Re: Coding style

2006-10-04 Thread Jim Jagielski
I don't understand all of this... Just because there were some bugs in some code because someone forgot the precendence rules for C should mean we abandon standard C idioms... while ((c = getchar()) != EOF) is like one of the 1st C "shortcuts" people learn and is SOP for C coding. -- ===

Re: Coding style

2006-10-04 Thread Jim Jagielski
Jim Jagielski wrote: > > rules for C should mean we abandon standard C idioms... shouldn't -- === Jim Jagielski [|] [EMAIL PROTECTED] [|] http://www.jaguNET.com/ "If

[PATCH] sendfile_nonblocking broken in trunk

2006-10-04 Thread Niklas Edmundsson
I stumbled upon this when porting the mod_disk_cache read-while-caching feature to trunk. r-w-c uses a diskcache bucket which it morphs into file buckets as more data becomes available. Ie, it starts with a brigade containing: FILE-DISKCACHE FILE is sendfile:d as usual by core_filters, and w

Re: [PATCH] sendfile_nonblocking broken in trunk

2006-10-04 Thread Graham Leggett
On Wed, October 4, 2006 4:14 pm, Niklas Edmundsson wrote: > sendfile_nonblocking() takes the _brigade_ as an argument, gets the > first bucket from the brigade, finds it not to be a FILE bucket and > barfs. > > The attached fix is trivial, and I really can't understand why > sendfile_nonblocking()

Re: Coding style

2006-10-04 Thread William A. Rowe, Jr.
Jim Jagielski wrote: > I don't understand all of this... Just because there were some > bugs in some code because someone forgot the precendence > rules for C should mean we abandon standard C idioms... > > while ((c = getchar()) != EOF) > > is like one of the 1st C "shortcuts" people learn

Re: Coding style

2006-10-04 Thread Jim Jagielski
I don't feel strongly enough about "all on one line" vs "assignment on one and test on another" to really push one over the other, however. But that comma method is an abomination ;) -- === Jim Jagielski [|] [EMAIL PROT

Re: Coding style

2006-10-04 Thread Nick Kew
On Wednesday 04 October 2006 19:04, Jim Jagielski wrote: > But that comma method is an abomination ;) Heh. Is a sequence of statements separated by semicolons an abomination too? -- Nick Kew

flood: enhancement - random string substitution in URL

2006-10-04 Thread Guy Ferraiolo
Folks I've developed some additional functionality for flood: random text substitution in the URL. It has been in use here for several years. I think this is a very useful addition and I'd like to see it become part of flood. The feature works in this way: the URL contains a string of the form

Re: flood: enhancement - random string substitution in URL

2006-10-04 Thread Ian Holsman
Hi Guy. unified diff format is preferred. you can email it to the list, or put it in a bug (or both) I'm not sure, but I think flood is maintained on a different list.. (it's been a while) --Ian On 05/10/2006, at 10:24 AM, Guy Ferraiolo wrote: Folks I've developed some additional funct

RE: flood: enhancement - random string substitution in URL

2006-10-04 Thread Guy Ferraiolo
Ian Thanks for the quick response. I have a unified diff prepared, the flood list was merged into httpd-dev the end of last year. I'm really glad I'm finally getting to do this. Whew. Guy > -Original Message- > From: Ian Holsman [mailto:[EMAIL PROTECTED] > Sent: Wednesday, October

[STATUS] (httpd-2.0) Wed Oct 4 23:51:37 2006

2006-10-04 Thread Rodent of Unusual Size
APACHE 2.0 STATUS: -*-text-*- Last modified at [$Date: 2006-09-13 15:45:30 -0400 (Wed, 13 Sep 2006) $] The current version of this file can be found at: * http://svn.apache.org/repos/asf/httpd/httpd/branches/2.0.x/STATUS Documentation status is main

[STATUS] (httpd-trunk) Wed Oct 4 23:51:12 2006

2006-10-04 Thread Rodent of Unusual Size
APACHE 2.3 STATUS: -*-text-*- Last modified at [$Date: 2006-08-22 16:41:03 -0400 (Tue, 22 Aug 2006) $] The current version of this file can be found at: * http://svn.apache.org/repos/asf/httpd/httpd/trunk/STATUS Documentation status is maintained se