Re: mod_deflate DoS using HEAD

2010-06-26 Thread Stefan Fritsch
On Tuesday 22 June 2010, Plüm, Rüdiger, VF-Group wrote: I am currently +0 on wether to use the patch above or my original proposal. Both have its pros and cons (Saving more CPU vs. be more picky about caching and implement an RFC SHOULD). I have now commited your original patch because it is

Some memory usage optimizations

2010-06-26 Thread Stefan Fritsch
Hi, there are some places where httpd uses more memory than necessary, which can increase cache misses and reduce performance on current hardware. Things I would like to change: 1) reorder structs to have fewer holes on 64bit arches httpd.h has this nice comment since the days of 1.3: /*

Re: Some memory usage optimizations

2010-06-26 Thread William A. Rowe Jr.
On 6/26/2010 1:49 PM, Stefan Fritsch wrote: Hi, there are some places where httpd uses more memory than necessary, which can increase cache misses and reduce performance on current hardware. Things I would like to change: 1) reorder structs to have fewer holes on 64bit arches Pro:

Re: Some memory usage optimizations

2010-06-26 Thread Stefan Fritsch
On Saturday 26 June 2010, William A. Rowe Jr. wrote: 2) Use char instead of int for the module_levels vector in struct ap_logconfig. The length of the vector is ~100. Pro: This may save ~300 bytes per server conf which are read often and therefore occupy CPU-cache memory Con: On

Re: Some memory usage optimizations

2010-06-26 Thread William A. Rowe Jr.
On 6/26/2010 5:27 PM, Stefan Fritsch wrote: But trunk has 110 modules already. Maybe we should increase DYNAMIC_MODULE_LIMIT from 128 to 192? With your proposed optimizations, we can take it to 256 with still a significant net win.. 3) In server/config.c, many config vectors are created