Re: svn commit: r992806 - in /httpd/httpd/trunk: ./ docs/manual/ docs/manual/mod/ include/ modules/loggers/ server/

2010-09-06 Thread Ruediger Pluem
On 09/05/2010 05:44 PM, s...@apache.org wrote: Author: sf Date: Sun Sep 5 15:44:19 2010 New Revision: 992806 URL: http://svn.apache.org/viewvc?rev=992806view=rev Log: Add ErrorLogFormat directive for configuring the error log format, including additional information that is logged once

Re: mod_cache: store_body() bites off more than it can chew

2010-09-06 Thread Niklas Edmundsson
On Fri, 3 Sep 2010, Graham Leggett wrote: snip Regarding the issue of the disk cache cramming the entire file into memory/address space, an alternate solution could be that the cache returns buckets pointing to the cached file, ie that the cache consumed those pesky mmapped buckets. This

Re: mod_cache: store_body() bites off more than it can chew

2010-09-06 Thread Graham Leggett
On 06 Sep 2010, at 11:52 AM, Niklas Edmundsson wrote: Regarding the issue of the disk cache cramming the entire file into memory/address space, an alternate solution could be that the cache returns buckets pointing to the cached file, ie that the cache consumed those pesky mmapped buckets.

Re: mod_cache: store_body() bites off more than it can chew

2010-09-06 Thread Niklas Edmundsson
On Mon, 6 Sep 2010, Graham Leggett wrote: snip For those who have forgotten, that's what we do in our large-file-caching-patchset for mod_disk_cache (hidden as an attachment to https://issues.apache.org/bugzilla/show_bug.cgi?id=39380 but I should really get around to upload an up2date version

Re: mod_cache: store_body() bites off more than it can chew

2010-09-06 Thread Dan Poirier
On 2010-09-06 at 05:52, Niklas Edmundsson ni...@acc.umu.se wrote: On Fri, 3 Sep 2010, Graham Leggett wrote: Been keen to do this for a while, this would definitely solve the RAM problem, but wouldn't solve the time problem. Copying 4GB of data from a slow disk can easily take minutes, and

Re: mod_cache: store_body() bites off more than it can chew

2010-09-06 Thread Paul Fee
Graham Leggett wrote: Given that the make-cache-writes-atomic problem requires a change to the data format, it may be useful to look at this now, before v2.4 is baked, which will happen soon. How much of a performance boost is the use-null-terminated-strings? Regards, Graham -- If

Re: mod_cache: store_body() bites off more than it can chew

2010-09-06 Thread Graham Leggett
On 06 Sep 2010, at 3:10 PM, Paul Fee wrote: If mod_disk_cache's on disk format is changing, now may be an opportunity to investigate some options to improve performance of httpd as a caching proxy. Currently headers and data are in separate files. If they were in a single file, the

Re: mod_cache: store_body() bites off more than it can chew

2010-09-06 Thread Niklas Edmundsson
On Mon, 6 Sep 2010, Paul Fee wrote: If mod_disk_cache's on disk format is changing, now may be an opportunity to investigate some options to improve performance of httpd as a caching proxy. Currently headers and data are in separate files. If they were in a single file, the operating system

code coverage using gcov

2010-09-06 Thread Paras Fadte
Hi, Trying to run gcov for all the compiled in modules in apache shows stamp mismatch with graph file . Has anyone come across this issue? Is this a known issue ? How can one get around this issue ? *Note*: Apache was started as ./httpd -X and then stopped as ./apachectl stop after making few

Re: svn commit: r992806 - in /httpd/httpd/trunk: ./ docs/manual/ docs/manual/mod/ include/ modules/loggers/ server/

2010-09-06 Thread Stefan Fritsch
On Monday 06 September 2010, Ruediger Pluem wrote: + +/* + * The apr-util docs wrongly states encoded strings are not 0-terminated. + * Let's be save and allocate an additional byte. + */ +len = 1 + apr_base64_encode_len(sizeof(id)); +encoded = apr_palloc(r

Re: mod_cache: store_body() bites off more than it can chew

2010-09-06 Thread Stefan Fritsch
On Monday 06 September 2010, Paul Fee wrote: Currently headers and data are in separate files. If they were in a single file, the operating system is given more indication that these two items are tightly coupled. For example, when the headers are read in, the O/S can readahead and buffer

Re: mod_cache: store_body() bites off more than it can chew

2010-09-06 Thread Paul Querna
On Thu, Sep 2, 2010 at 10:16 AM, Graham Leggett minf...@sharp.fm wrote: Hi all, An issue with mod_cache I would like to address this weekend is the definition of the store_body() function in the cache implementation provider:    apr_status_t (*store_body)(cache_handle_t *h, request_rec *r,