Re: mod_substitute tags parsing

2010-11-07 Thread Nick Gearls
If somebody from mod_log_config wants to discuss with me to generalise the code to be usable also without request_rec/server_req and pools, I can try to do it cleanly for the first patch proposal. Any idea why I cannot obtain the handlers via apr_hash_get()? Or maybe what I could check to

Re: mod_substitute tags parsing

2010-11-07 Thread Nick Gearls
Actually, the problem is that apr_table_get(r-subprocess_env, a) always returns null. I suppose that the problem lies in the request variable r. I am using f-r where f is the ap_filter_t given as parameter to do_pattmatch(). Should I use another one, Thanks, Nick Original Message

Bug report for Apache httpd-1.3 [2010/11/07]

2010-11-07 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Re: mod_substitute tags parsing

2010-11-07 Thread Stefan Fritsch
On Sun, 7 Nov 2010, Nick Gearls wrote: Actually, the problem is that apr_table_get(r-subprocess_env, a) always returns null. I suppose that the problem lies in the request variable r. I am using f-r where f is the ap_filter_t given as parameter to do_pattmatch(). Should I use another one,

Re: mod_substitute tags parsing

2010-11-07 Thread Stefan Fritsch
Sorry, I was not clear enough. mod_log_config provides CustomLog/LogFormat and should work very similar to what mod_headers does. It should be relatively easy to make them use the same code. ErrorLog/ErrorLogFormat is provided by the core and works differently (due to lack of request_rec,

Re: svn commit: r1032059 - /httpd/httpd/trunk/modules/filters/mod_include.c

2010-11-07 Thread Graham Leggett
On 06 Nov 2010, at 10:32 PM, Stefan Fritsch wrote: I think I have made my intentions clear in my first mail from October 23rd. But maybe I should have mentioned it also in the later mails. The grammar and in particular the string handling in the SSI expression parser is so weird that it

Re: svn commit: r1032286 - /httpd/httpd/trunk/modules/proxy/mod_proxy.h

2010-11-07 Thread Jeff Trawick
On Sun, Nov 7, 2010 at 9:35 AM, traw...@apache.org wrote: Author: trawick Date: Sun Nov  7 14:35:21 2010 New Revision: 1032286 URL: http://svn.apache.org/viewvc?rev=1032286view=rev Log: improve wording of some function descriptions add explicit FIXME to an ancient issue remove implicit

Re: mod_substitute tags parsing

2010-11-07 Thread Nick Gearls
%D works, but, for instance, not %{proxy-sendcl}e which is set with setenv proxy-sendcl. I call process_tags() in do_pattmatch() right after the initialisations. This may be the cause? Should I call it inside substitute_filter()? I tried but I got the same result :-( Nick Original

Re: svn commit: r1032345 - /httpd/httpd/trunk/modules/proxy/mod_proxy_fcgi.c

2010-11-07 Thread Jeff Trawick
On Sun, Nov 7, 2010 at 1:54 PM, traw...@apache.org wrote: Author: trawick Date: Sun Nov  7 18:54:44 2010 New Revision: 1032345 URL: http://svn.apache.org/viewvc?rev=1032345view=rev Log: mark connection for close after the return from ap_proxy_determine_connection() before this revision:

New key for j...@apache.org

2010-11-07 Thread Jim Jagielski
Resending w/ GPG sig. Need at least a few sigs before I can TR httpd 2.3.9-alpha! Seemed about time to finally upgrade my key to 4096... Just did it. Created and then signed by my old key. So please go ahead and sign this new one as well; of course, to be doubly-sure, feel free to grab me @ AC

Re: New key for j...@apache.org

2010-11-07 Thread Rainer Jung
On 07.11.2010 20:36, Jim Jagielski wrote: Resending w/ GPG sig. Need at least a few sigs before I can TR httpd 2.3.9-alpha! Done. Isn't it for the moment enough that you signed it with your already trusted key? Only when 1024 effectvely becomes breakable this wouldn't be valid any longer.

Filter Scoreboard Entries

2010-11-07 Thread Brian J. France
$DAY job requires filtering the scoreboard for things like username, passwords, credit card numbers (don't ask) and other sensitive information. Currently I just added a patch to our build that adds a option function that I set in our filtering module. While at ApacheCon I talked with Paul

[RFC] Error directive to generate custom error messages from httpd.conf

2010-11-07 Thread Jeff Trawick
This is handy when a module depends on another module at load time or run time, and the config for that module needs to display a message more helpful than the normal symbol-not-found or optional-function-not-found or invalid-filter message. The current kludge for generating an error message is

Re: [RFC] Error directive to generate custom error messages from httpd.conf

2010-11-07 Thread Dan Poirier
Cute. Always nice to have better error reporting.

Re: [RFC] Error directive to generate custom error messages from httpd.conf

2010-11-07 Thread Graham Leggett
On 08 Nov 2010, at 2:35 AM, Jeff Trawick wrote: With the Error directive: IfModule !mod_include.c Error mod_foo requires mod_include! Use the LoadModule directive to load mod_include. /IfModule $ ./httpd -t Syntax error on line 486 of /home/trawick/inst/23/conf/httpd.conf: mod_foo requires

Re: [RFC] Error directive to generate custom error messages from httpd.conf

2010-11-07 Thread Jeff Trawick
On Sun, Nov 7, 2010 at 8:13 PM, Graham Leggett minf...@sharp.fm wrote: On 08 Nov 2010, at 2:35 AM, Jeff Trawick wrote: With the Error directive: IfModule !mod_include.c Error mod_foo requires mod_include!  Use the LoadModule directive to load mod_include. /IfModule $ ./httpd -t Syntax

Re: [RFC] Error directive to generate custom error messages from httpd.conf

2010-11-07 Thread Sander Temme
On Nov 7, 2010, at 4:35 PM, Jeff Trawick wrote: This is handy when a module depends on another module at load time or run time, and the config for that module needs to display a message more helpful than the normal symbol-not-found or optional-function-not-found or invalid-filter message.

Re: [RFC] Error directive to generate custom error messages from httpd.conf

2010-11-07 Thread Dan Poirier
On Sun. 2010-11-07 at 08:29 PM EST, Sander Temme scte...@apache.org wrote: Pardon my rust, but what actually makes the process error out? Returning !nil? Right, config handlers either return NULL or an error message, and that fails startup.

Re: [RFC] Error directive to generate custom error messages from httpd.conf

2010-11-07 Thread Jeff Trawick
On Sun, Nov 7, 2010 at 8:29 PM, Sander Temme scte...@apache.org wrote: On Nov 7, 2010, at 4:35 PM, Jeff Trawick wrote: This is handy when a module depends on another module at load time or run time, and the config for that module needs to display a message more helpful than the normal

Re: [RFC] Error directive to generate custom error messages from httpd.conf

2010-11-07 Thread Sander Temme
On Nov 7, 2010, at 5:35 PM, Jeff Trawick wrote: +1. We also discussed last week the possibility that a module provides functionality not captured in the config file, and server startup should fail if that module is not loaded. The example I remember discussing was some module (or even

Re: svn commit: r1032073 [1/3] - in /httpd/httpd/trunk: ./ include/ modules/aaa/ modules/filters/ modules/metadata/ modules/ssl/ server/

2010-11-07 Thread Ruediger Pluem
On 11/06/2010 03:31 PM, s...@apache.org wrote: Author: sf Date: Sat Nov 6 14:31:16 2010 New Revision: 1032073 URL: http://svn.apache.org/viewvc?rev=1032073view=rev Log: Replace ap_expr with a parser derived from mod_ssl's parser. Make mod_ssl use the new parser. Rework ap_expr's public