Re: id=51247 Enhance mod_proxy and _balancer with worker status flag to only accept sticky session routes

2011-05-25 Thread Mladen Turk
On 05/25/2011 02:27 AM, Daniel Ruggeri wrote: I attached the patch to a bug opened by Cameron Stokes https://issues.apache.org/bugzilla/show_bug.cgi?id=48841 Just a quick note on the first thing I saw: +//worker->lbfactor = atoi(val); +worker->lbfactor = strtol(val, NULL, 10);

Re: id=51247 Enhance mod_proxy and _balancer with worker status flag to only accept sticky session routes

2011-05-25 Thread Jim Jagielski
On May 24, 2011, at 8:27 PM, Daniel Ruggeri wrote: > > Jim, if you wouldn't mind reviewing both and suggesting one to be cleaned up > for a patch generated against trunk. I'm happy to volunteer the effort to > adjust my patch or at least take care of that bug that's out there still. > Will d

Re: id=51247 Enhance mod_proxy and _balancer with worker status flag to only accept sticky session routes

2011-05-25 Thread Keith Mashinter
I've reviewed the other patch https://issues.apache.org/bugzilla/show_bug.cgi?id=48841 and I had a similar idea, wondering if the route-only intent would happen if I tried to set lbfactor=0 but it only allowed values 1-100 and I worried about the complexity of changing the lbmethod formulae so

Re: id=51247 Enhance mod_proxy and _balancer with worker status flag to only accept sticky session routes

2011-05-25 Thread Daniel Ruggeri
On 5/25/2011 5:41 AM, Mladen Turk wrote: On 05/25/2011 02:27 AM, Daniel Ruggeri wrote: I attached the patch to a bug opened by Cameron Stokes https://issues.apache.org/bugzilla/show_bug.cgi?id=48841 Just a quick note on the first thing I saw: + //worker->lbfactor = atoi(val); + worker->lbfac

Re: [PATCH] New default sort order in Apache-Test-1.36 (WAS: test framework and latest Fedora)

2011-05-25 Thread Fred Moyer
+1 Do you have commit privileges on Apache-Test? On Fri, May 20, 2011 at 1:51 PM, Rainer Jung wrote: > I noticed, that the SMOKE change in 1.36 also introduced a new sorting > behaviour. In the change the test suite was running by default using the > repeat order, that means the tests were order