Pull request: server/util_md5.c:58 - replace magic number with constant arithmetic

2012-08-29 Thread SiPlus
Hello, dev@. I request a little change to HTTPD code. On line 58 of server/util_md5.c, please replace char *r, result[33]; /* (MD5_DIGESTSIZE * 2) + 1 */ with char *r, result[2*APR_MD5_DIGESTSIZE+1]; There's only constant arithmetic here, so I don't see a reason to pre-calculate the

Re: Pull request: server/util_md5.c:58 - replace magic number with constant arithmetic

2012-08-29 Thread pqf
Some C compilers don't support this: result[2*APR_MD5_DIGESTSIZE+1] ? Hello, dev@. I request a little change to HTTPD code. On line 58 of server/util_md5.c, please replace char *r, result[33]; /* (MD5_DIGESTSIZE * 2) + 1 */ with char *r, result[2*APR_MD5_DIGESTSIZE+1]; There's

Re: [Vote] httpd 2.2.23 release

2012-08-29 Thread Michael Felt
Not this time, but I have in the past. Need to automate the key-generation, etc. for https:// - sounds like a ToDo! Good reminder. On Mon, Aug 27, 2012 at 3:58 PM, Guenter Knauf fua...@apache.org wrote: Hi Michael, Am 27.08.2012 15:42, schrieb Michael Felt: No package 'openssl' found that

Re: [Vote] httpd 2.2.23 release

2012-08-29 Thread Michael Felt
Guenter, working on it - after generating a test key, turning on two mod_'s and adding extra/*ssl.conf I was able to do: $ openssl s_client -connect localhost:443 -state -debug GET / HTTP/1.0 snip - from end: 00d0 - 99 7a 90 ca 1c 28 b4 3e-a9 af 26 d4 cd 33 88 99 .z...(.3.. 00e0 - bf de