Re: stop copying footers to r-headers_in?

2013-10-28 Thread Yann Ylavic
The declaration of ap_get_mime_headers_from() is falsy in the previous patch, you should read instead : +AP_DECLARE(apr_status_t) +ap_get_mime_headers_from(request_rec *r, apr_bucket_brigade *bb, + ap_filter_t *from, apr_read_type_e block, +

mod_ssl: why do we flush on EOS in ssl_io_filter_output()?

2013-10-28 Thread Graham Leggett
Hi all, I am currently trying to find out why mod_ssl stops CONN_STATE_WRITE_COMPLETION from working correctly, and have noticed that for no clear reason, mod_ssl flushes the output filters when it receives an EOS bucket:

RE: mod_ssl: why do we flush on EOS in ssl_io_filter_output()?

2013-10-28 Thread Plüm , Rüdiger , Vodafone Group
-Original Message- From: Graham Leggett [mailto:minf...@sharp.fm] Sent: Montag, 28. Oktober 2013 16:52 To: dev@httpd.apache.org Subject: mod_ssl: why do we flush on EOS in ssl_io_filter_output()? Hi all, I am currently trying to find out why mod_ssl stops

Re: mod_ssl: why do we flush on EOS in ssl_io_filter_output()?

2013-10-28 Thread Eric Covener
On Mon, Oct 28, 2013 at 11:52 AM, Graham Leggett minf...@sharp.fm wrote: Hi all, I am currently trying to find out why mod_ssl stops CONN_STATE_WRITE_COMPLETION from working correctly, and have noticed that for no clear reason, mod_ssl flushes the output filters when it receives an EOS

Re: mod_ssl: why do we flush on EOS in ssl_io_filter_output()?

2013-10-28 Thread Eric Covener
On Mon, Oct 28, 2013 at 12:22 PM, Eric Covener cove...@gmail.com wrote: On Mon, Oct 28, 2013 at 11:52 AM, Graham Leggett minf...@sharp.fm wrote: Hi all, I am currently trying to find out why mod_ssl stops CONN_STATE_WRITE_COMPLETION from working correctly, and have noticed that for no

[Patch] mod_ssl write completion

2013-10-28 Thread Graham Leggett
Hi all, I was on the wrong track with regards mod_ssl and the flush-on-eos, the patch below to mod_ssl echoes a similar strategy the core output filter uses to enter write completion mode. The idea is that if the brigade to be written contains an EOS bucket but not a flush bucket, we can