Re: svn commit: r1584941 - /httpd/httpd/branches/2.4.x/STATUS

Hi, I've gone quickly thru the module and I have a few remarks: - What is the use of FN_LOG_MARK on line 87? Couldn't we use APLOG_MARK instead? 'connect_to_peer' is called only in one place with module_index=APLOG_MODULE_INDEX - Do things like AP_MODULE_MAGIC_AT_LEAST(20130702,2

Re: [PATCH 55467] - Updates to mod_ssl to support TLS hello extensions and TLS supplemental data

On Tue, Feb 18, 2014 at 3:50 PM, Scott Deboy wrote: > Hi folks, > > I was wondering if someone would be willing/interested in reviewing the > patch I've attached to issue 55467. > > https://issues.apache.org/bugzilla/show_bug.cgi?id=55467 > > The patch adds hooks to mod_ssl which give third-party

Re: mod_proxy ping and 100-continue (was Re: NOTE: Intent to T&R 2.2.6 tomorrow)

This is a once-per-request query, so a note shouldn't be a bad thing. But I'm wondering if we need a multi-state (and eventually, fold that into 2.6/3.0 req_req instead)? Many users have requested that mod_proxy honor -configured- proxypass backends' 100 responses and defer the 100 response to the

Re: svn commit: r1584582 - /httpd/httpd/branches/2.4.x/STATUS

On Fri, Apr 4, 2014 at 9:35 PM, Marion & Christophe JAILLET wrote: > Just in case, removal of compatibility notes against 2.3.x has been > discussed a few months ago. > See http://marc.info/?t=13861912831&r=1&w=2 > > No real concensus about it. Ouch, I already backported the changes. Should I

Re: mod_proxy ping and 100-continue (was Re: NOTE: Intent to T&R 2.2.6 tomorrow)

On Fri, Apr 4, 2014 at 7:52 PM, Jim Jagielski wrote: > Is there any way to accomplish w/o using notes? It's not that > they are especially slow, it's just that they aren't that fast > and, iirc, this could be a tight path. There surely is, but we can't use the proxy_conn_rec for this (it may chan

Re: mod_proxy duplicated its headers on next balancer's worker or 100-continue ping retries

On Fri, Apr 4, 2014 at 8:38 PM, Ruediger Pluem wrote: > Why can't we fix that directly in ap_proxy_create_hdrbrgd? Actually we can, and that's indeed a much simpler patch. I was worried about modifications of "Content-Length" and/or "Transfer-Encoding" outside ap_proxy_create_hdrbrgd() (ie. in a

Re: svn commit: r1584582 - /httpd/httpd/branches/2.4.x/STATUS

Le 04/04/2014 13:59, Yann Ylavic a écrit : On Fri, Apr 4, 2014 at 1:35 PM, Eric Covener wrote: FYI not necessary to propose docs-only changes in STATUS, they are CTR. Oh, I see, thanks for the information. Should I (or one) backport it if no one else screams for a while then? Just in case,

Re: mod_proxy duplicated its headers on next balancer's worker or 100-continue ping retries

Why can't we fix that directly in ap_proxy_create_hdrbrgd? Regards Rüdiger Yann Ylavic wrote: > Here is the patch not polluted by working collisions or gotos : >

Re: mod_proxy ping and 100-continue (was Re: NOTE: Intent to T&R 2.2.6 tomorrow)

Is there any way to accomplish w/o using notes? It's not that they are especially slow, it's just that they aren't that fast and, iirc, this could be a tight path. On Apr 4, 2014, at 1:02 PM, Yann Ylavic wrote: > Hi, > > this is the day of resurrections :p > > I think I've got a simpler way to

Re: Apache Modules: Source Code and Headers??

On Fri, Apr 4, 2014 at 1:07 PM, Eric Covener wrote: > Source releases: http://httpd.apache.org/download.cgi#apache24 > How to access via SCM: http://httpd.apache.org/dev/devnotes.html > > On Fri, Apr 4, 2014 at 1:02 PM, Miguel Villarreal > wrote: >> Hi, where can I find the C source codes of Apac

Re: Apache Modules: Source Code and Headers??

Source releases: http://httpd.apache.org/download.cgi#apache24 How to access via SCM: http://httpd.apache.org/dev/devnotes.html On Fri, Apr 4, 2014 at 1:02 PM, Miguel Villarreal wrote: > Hi, where can I find the C source codes of Apache and headers. > > I have been trying to finde them in the Apa

Re: mod_proxy ping and 100-continue (was Re: NOTE: Intent to T&R 2.2.6 tomorrow)

Hi, this is the day of resurrections :p I think I've got a simpler way to address this issue, that is, don't send unexpected 100-continue to clients due to proxy ping feature. Here is the patch. Once again, please object if you don't want me to commit this stuff. Reagrds, Yann. Index: modules/

Apache Modules: Source Code and Headers??

Hi, where can I find the C source codes of Apache and headers. I have been trying to finde them in the Apache website but I have not been able to find them. I found them in other pages, but I have doubts about if they are the original (without users' changes). Please let me know. Miguel Antonio

Re: mod_proxy duplicated its headers on next balancer's worker or 100-continue ping retries

Here is the patch not polluted by working collisions or gotos : Index: modules/proxy/mod_proxy_wstunnel.c === --- modules/proxy/mod_proxy_wstunnel.c(revision 1584652) +++ modules/proxy/mod_proxy_wstunnel.c(working copy) @@ -32

Re: mod_proxy duplicated its headers on next balancer's worker or 100-continue ping retries

On Fri, Apr 4, 2014 at 6:22 PM, Jim Jagielski wrote: > This seems to change some logic which appear only tangentially > associated w/ the "save headers" issue... why is that? Do you mean, ... > > On Apr 4, 2014, at 11:43 AM, Yann Ylavic wrote: >> Index: modules/proxy/mod_proxy_http.c >> ===

Re: How to modify a core module of Apache

On Fri, Apr 4, 2014 at 6:14 PM, Miguel Villarreal wrote: > Where can I get the C code of a specific module in Apache? The sources archives of released versions are available from download page: http://httpd.apache.org/download.cgi. If you want the dev version (trunk), go to this page instead: htt

Re: mod_proxy duplicated its headers on next balancer's worker or 100-continue ping retries

This seems to change some logic which appear only tangentially associated w/ the "save headers" issue... why is that? On Apr 4, 2014, at 11:43 AM, Yann Ylavic wrote: > Index: modules/proxy/mod_proxy_http.c > === > --- modules/proxy/m

How to modify a core module of Apache

Hello. Where can I get the C code of a specific module in Apache? Thank you! Miguel Antonio

Re: mod_proxy duplicated its headers on next balancer's worker or 100-continue ping retries

Helo, I revive this thread since headers in modfied by mod_proxy seems wrong to me, I have to take that into account when, say, analysing access logs (received X-Forwarded-* or Via headers vs the ones added by mod_proxy, see also PR 45387), or as said in the title, which is even worse when backend

Re: svn commit: r1584582 - /httpd/httpd/branches/2.4.x/STATUS

On Fri, Apr 4, 2014 at 7:59 AM, Yann Ylavic wrote: > On Fri, Apr 4, 2014 at 1:35 PM, Eric Covener wrote: >> FYI not necessary to propose docs-only changes in STATUS, they are CTR. > > Oh, I see, thanks for the information. > Should I (or one) backport it if no one else screams for a while then?

Re: svn commit: r1584417 - in /httpd/httpd/trunk: docs/manual/rewrite/flags.xml modules/mappers/mod_rewrite.c

On Fri, Apr 4, 2014 at 1:15 PM, Eric Covener wrote: > However this is another part of the escaping here that is wrong half the > time. It you're not substituting into the query string, we want c2x. Agreed, POST vars spaces (application/x-www-form-urlencoded) for example should be %20-encoded (al

Re: svn commit: r1584582 - /httpd/httpd/branches/2.4.x/STATUS

On Fri, Apr 4, 2014 at 1:35 PM, Eric Covener wrote: > FYI not necessary to propose docs-only changes in STATUS, they are CTR. Oh, I see, thanks for the information. Should I (or one) backport it if no one else screams for a while then?

Re: svn commit: r1584582 - /httpd/httpd/branches/2.4.x/STATUS

On Fri, Apr 4, 2014 at 5:44 AM, wrote: > + * manuals: Remove modules' compatibility references to httpd < 2.4 and > + OpenSSL < 0.9.8. > + trunk patch: http://svn.apache.org/r1584555 > + http://svn.apache.org/r1584572 > + 2.4.x patch: > https://people.apac

Re: Which Apache module write the access log file

On Thu, Apr 3, 2014 at 11:45 PM, Miguel Villarreal wrote: > Whe can I find a non-bug version of the different modules of Apache. I need > the module mod_log_config for version 2.4.7 Please continue here: http://httpd.apache.org/userslist.html

Re: svn commit: r1584417 - in /httpd/httpd/trunk: docs/manual/rewrite/flags.xml modules/mappers/mod_rewrite.c

On Fri, Apr 4, 2014 at 3:16 AM, Ruediger Pluem wrote: > Hmm. What about the special case to escape ' ' to '+' and not to a hex > value in this case? Good catch. This one sat on the shelf a bit so I am not sure, probably unintentional. However this is another part of the escaping here that is w

svn commit: 1573360 - SSLPassPhraseDialog arguments changed in 2.4.x

Hi, commit 1553824 (1573360 in 2.4.x) breaks the compatibility in arguments passed to "exec:/path/to/program" pass phrase program. This should be clear from the following part of mentioned commit(s): -argv[1] = cpVHostID; -argv[2] = cpAlgoType; -argv[3] = NULL; +

Re: Turn off SSL session tickets

Dr Stephen Henson wrote: > On 10/03/2014 10:22, Plüm, Rüdiger, Vodafone Group wrote: >> Reading the trunk documentation it seems possible to turn off SSL session >> tickets via >> >> SSLOpenSSLConfCmd Options -SessionTicket >> >> I assume there are no other options doing so on 2.2.x and 2.4.x, c

Re: svn commit: r1584098 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_ssl.xml modules/ssl/ssl_engine_ocsp.c modules/ssl/ssl_private.h

On Fri, Apr 4, 2014 at 9:57 AM, Yann Ylavic wrote: > On Fri, Apr 4, 2014 at 9:55 AM, Yann Ylavic wrote: >> I can now remove this requirement from all... > And maybe the availability in httpd 2.3 and later too. Done in r1584555.

Re: svn commit: r1584098 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_ssl.xml modules/ssl/ssl_engine_ocsp.c modules/ssl/ssl_private.h

On Fri, Apr 4, 2014 at 9:55 AM, Yann Ylavic wrote: > I can now remove this requirement from all... And maybe the availability in httpd 2.3 and later too.

Re: svn commit: r1584098 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_ssl.xml modules/ssl/ssl_engine_ocsp.c modules/ssl/ssl_private.h

On Fri, Apr 4, 2014 at 9:21 AM, Ruediger Pluem wrote: > > > Eric Covener wrote: >> >> On Thu, Apr 3, 2014 at 7:06 PM, Yann Ylavic > > wrote: >> >> > +Available in httpd 2.4.10 and later, if using OpenSSL >> 0.9.7 or later > > Hmm. Isn't OpenSSL >= 0.9.8 already manda

Re: svn commit: r1584098 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_ssl.xml modules/ssl/ssl_engine_ocsp.c modules/ssl/ssl_private.h

Eric Covener wrote: > > On Thu, Apr 3, 2014 at 7:06 PM, Yann Ylavic > wrote: > > > +Available in httpd 2.4.10 and later, if using OpenSSL > 0.9.7 or later Hmm. Isn't OpenSSL >= 0.9.8 already mandatory for httpd 2.4.x? Regards Rüdiger

Re: svn commit: r1584417 - in /httpd/httpd/trunk: docs/manual/rewrite/flags.xml modules/mappers/mod_rewrite.c

cove...@apache.org wrote: > Author: covener > Date: Thu Apr 3 21:53:14 2014 > New Revision: 1584417 > > URL: http://svn.apache.org/r1584417 > Log: > allow users to workaround the over-agressive backreference > escaping by selecting the characters to escape. > > > Modified: > httpd/httpd/