Re: [users@httpd] Preserve protocol in httpd proxy

2014-05-31 Thread Jim Jagielski
I'm sure we can do w/ mod_rewrite... it's just that it's soo expensive :) On May 30, 2014, at 3:40 PM, Ruediger Pluem wrote: > > > Jim Jagielski wrote: >> Off the top of my head, I think we would need to >> add another proxypass option. > > Have you tried the following? > > RewriteEngine On

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-05-31 Thread Jim Jagielski
Sorry I didn't catch this earlier: I see +++ httpd-trunk.new/include/mpm_common.h2014-05-16 13:07:03.892987491 -0400 @@ -267,16 +267,18 @@ * Write data to the pipe-of-death, signalling that one child process * should die. * @param pod the pipe-of-death to write to. + * @param my_bu

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-05-31 Thread Jim Jagielski
I also see: /* kill off the idle ones */ -ap_mpm_pod_killpg(pod, retained->max_daemons_limit); +for (i = 0; i < num_buckets; i++) { +ap_mpm_pod_killpg(pod[i], i, retained->max_daemons_limit); +} Is that right? Why isn't it: ap_mpm_pod_killpg(pod, ret

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-05-31 Thread Lu, Yingqi
Hi Jim, Thanks very much for your email! I will look into both of them and send an update tonight! Thanks, Yingqi > On May 31, 2014, at 9:43 AM, "Jim Jagielski" wrote: > > I also see: > > /* kill off the idle ones */ > -ap_mpm_pod_killpg(pod, retained->max_daemons_limit); > +

Re: Issue with connect() call made in mod_proxy_fdpass?

2014-05-31 Thread Christophe JAILLET
There is also the same kind of code in apr/misc/unix/rand.c. In this case, the +1 is missing. I think that line 157 of 'rand.c' should be changed in: egd_path_len = strlen(*egdsockname) + 1; in order to take into account the '\0' that is expedted at the end of sun_path. CJ Le 31/05/2

RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-05-31 Thread Lu, Yingqi
Hi Jim, Regarding to your comment #2, yes, you are right, it should be ap_mpm_pod_killpg(pod, retained->max_daemons_limit, i). Thanks very much for catching this. Regarding to your comment #1, the patch modifies the dummy_connection(ap_pod_t *pod) to be dummy_connection(ap_pod_t *pod, int chil

Re: Issue with connect() call made in mod_proxy_fdpass?

2014-05-31 Thread Christophe JAILLET
Fix in r1598946. CJ