Re: svn commit: r1599501 - in /httpd/httpd/branches/2.4.x: ./ modules/aaa/ modules/filters/ modules/mappers/ modules/metadata/ modules/proxy/ server/ server/mpm/event/

2014-06-03 Thread Yann Ylavic
Argh, it seems that module/proxy/scgi.h is missing in 2.4.x (added in trunk by r1592615), hence : proxy_util.c:25:18: error: scgi.h: No such file or directory proxy_util.c:3491: error: ‘SCGI_DEF_PORT’ undeclared here (not in a function) On Tue, Jun 3, 2014 at 2:14 PM, wrote: > Author: jim > Dat

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-06-03 Thread Jim Jagielski
I have folded this into trunk and am currently fixing some compile warnings and errors... On Jun 2, 2014, at 4:22 AM, Lu, Yingqi wrote: > Hi Jim, > > Personally, I think the second approach is better, it keeps ap_mpm_pod_signal > () and ap_mpm_pod_killpg () exactly as the original ones, only m

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-06-03 Thread Jim Jagielski
FTR: I saw no reason to try to handle both patches... I used the so_reuseport patch as the primary patch to focus on. I have some minor changes coming up to follow-up post the initial commit On Jun 3, 2014, at 8:51 AM, Jim Jagielski wrote: > I have folded this into trunk and am currently fixing

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-06-03 Thread Jim Jagielski
Next on the agenda is to push into eventopt On Jun 3, 2014, at 10:21 AM, Jim Jagielski wrote: > FTR: I saw no reason to try to handle both patches... I used > the so_reuseport patch as the primary patch to focus on. > > I have some minor changes coming up to follow-up post > the initial commit

RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-06-03 Thread Lu, Yingqi
Thank you very much for your help! Thanks, Yingqi -Original Message- From: Jim Jagielski [mailto:j...@jagunet.com] Sent: Tuesday, June 03, 2014 8:31 AM To: dev@httpd.apache.org Subject: Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support Next on the agenda is to

Re: svn commit: r1599641 - in /httpd/httpd/trunk: include/ap_mmn.h include/util_time.h server/mpm/event/event.c server/mpm/eventopt/eventopt.c server/mpm/prefork/prefork.c server/mpm/worker/worker.c s

2014-06-03 Thread Mike Rumph
Hello Jim, There is a small typo here. s/many operationg systems/many operating systems/ Thanks, Mike Rumph On 6/3/2014 9:02 AM, j...@apache.org wrote: Author: jim Date: Tue Jun 3 16:02:44 2014 New Revision: 1599641 URL: http://svn.apache.org/r1599641 Log: Break out common code to be share

Re: svn commit: r1572905 - /httpd/httpd/trunk/server/connection.c

2014-06-03 Thread Christophe JAILLET
Hi, while looking for backport candidates to synch 2.4.x and trunk, I came accross this one. I don't see where it "avoids a double apr_time_now() call on the first succeeding read". Because of the 'continue' after the 'timeup' computation, I think that the previous code already had only one ap