Re: Unhappy interactions between AIX, apxs, instdso.sh, apr/build-1/libtool and php

2014-06-20 Thread Michael Felt
Here is the patch - as text, and a file (not sure what normal is, but since it is small doing both). I moved $DLNAME != $TARGET_NAME test up because it seems more logical to try and let this bit resolve any issue before testing for the existance of $TARGET_NAME Then, if $TARGET_NAME is still miss

Re: Unhappy interactions between AIX, apxs, instdso.sh, apr/build-1/libtool and php

2014-06-20 Thread Victor J. Orlikowski
On Jun 20, 2014, at 12:35 PM, Michael Felt wrote: > At least, I am assuming this to be the problem - because I am assuming the > expectation is that $TARGET_NAME has been installed - unless DLNAME != > TARGET_NAME - because in that case DLNAME gets moved. > > Unfortunately, what has been instal

Re: Unhappy interactions between AIX, apxs, instdso.sh, apr/build-1/libtool and php

2014-06-20 Thread Michael Felt
Revisiting. First I looked at apxs using perl debug mode: Getting to the core: it looks like apxs is working fine: It gets to where it calls instdso.sh and the second command (chmod) fails. DB<1> apxs::(/opt/httpd/sbin/apxs:525): &execute_cmds(@cmds); DB<1> x @cmds 0 '/var/httpd/bu

Re: svn commit: r1603863 - in /httpd/httpd/trunk/modules: aaa/mod_auth_basic.c http/http_filters.c

2014-06-20 Thread Jim Jagielski
However, in general, I agree w/ the basic idea of having bitfields defined as unsigned ints, not because I like the idea of somehow using these bitfields as "tiny" signed ints but because it's better for packing and alignment purposes. So I'm not against the commit at all. We are using, afaik, al

Re: svn commit: r1603863 - in /httpd/httpd/trunk/modules: aaa/mod_auth_basic.c http/http_filters.c

2014-06-20 Thread Jim Jagielski
What I meant was "true or false"... Sorry for the confusion. On Jun 20, 2014, at 9:06 AM, Yann Ylavic wrote: > I can't agree with you on this. > > You first say a bit is either 0 or 1, which is not true for a signed > bit (0 or -1), and confirms somehow we should use unsigned here. > A good com

Re: svn commit: r1603863 - in /httpd/httpd/trunk/modules: aaa/mod_auth_basic.c http/http_filters.c

2014-06-20 Thread Yann Ylavic
I can't agree with you on this. You first say a bit is either 0 or 1, which is not true for a signed bit (0 or -1), and confirms somehow we should use unsigned here. A good compiler should also complain about setting 1 to something that can only take 0 or -1, and we did that before this commit. Th

Re: svn commit: r1603863 - in /httpd/httpd/trunk/modules: aaa/mod_auth_basic.c http/http_filters.c

2014-06-20 Thread Jim Jagielski
Besides that, any compiler worth its salt should complain. On Jun 20, 2014, at 7:50 AM, Jim Jagielski wrote: > Who does that w/ bit fields? You either check if it's > true/false or you use the expected bit operations. > > On Jun 19, 2014, at 9:29 AM, Yann Ylavic wrote: > >> On Thu, Jun 19, 20

Re: svn commit: r1603863 - in /httpd/httpd/trunk/modules: aaa/mod_auth_basic.c http/http_filters.c

2014-06-20 Thread Jim Jagielski
Who does that w/ bit fields? You either check if it's true/false or you use the expected bit operations. On Jun 19, 2014, at 9:29 AM, Yann Ylavic wrote: > On Thu, Jun 19, 2014 at 2:59 PM, Jim Jagielski wrote: >> >> On Jun 19, 2014, at 8:43 AM, yla...@apache.org wrote: >> >>> Author: ylavic >>

Re: svn commit: r1499351 - in /httpd/httpd/trunk: include/ap_mmn.h include/mod_auth.h modules/aaa/mod_auth_basic.c modules/aaa/mod_auth_digest.c

2014-06-20 Thread Eric Covener
On Fri, Jun 20, 2014 at 1:21 AM, Christophe JAILLET wrote: > Hi, > > while looking at backport candidate to synch 2.4 and trunk, I found this > commit. > > It seems harmless to me, so could be a good candidate. > Actually, it should be no use in module provided with apache, because none > seems to

Re: Log pollution from mod fcgid

2014-06-20 Thread Yann Ylavic
Thanks for your patch (and patience). Commited in http://svn.apache.org/r1604123. On Fri, Jun 20, 2014 at 11:40 AM, Mario Brandt wrote: > Hi, > > I had filed a bug[1] about mod fcgid polluting my apache error log. > So far no commiter had reviewed my patch. > > Can someone please take a look that

Log pollution from mod fcgid

2014-06-20 Thread Mario Brandt
Hi, I had filed a bug[1] about mod fcgid polluting my apache error log. So far no commiter had reviewed my patch. Can someone please take a look that patch? My logs have tons of lines like [Fri Jun 20 11:16:32.321859 2014] [fcgid:warn] [pid 2828:tid 504] mod_fcgid: process 7404 graceful kill fai