Re: Question about async mod_proxy_wstunnel and threads

2014-07-19 Thread Eric Covener
I guess it is kind of telling that we could still respond to the write from client 2, there are probably more potential errors that make us lose track of both sides simultaneously. Can you share your ws client and server if they're easy to use? My little sample doesn't spray that way. I'm also

Question about APLOGNO

2014-07-19 Thread Christophe JAILLET
Hi, I was wondering if logged message, at least APLOG_ERR or APLOG_EMERG and APLOG_CRIT, should all have a corresponding APLOGNO()? Using the following regex: ap_log_.?error.*(_ERR|_EMERG|_CRIT)[^A]*$ many places with missing APLOGNO can be found. There are some false positives because

Re: Question about APLOGNO

2014-07-19 Thread Jeff Trawick
On Sat, Jul 19, 2014 at 2:04 PM, Christophe JAILLET christophe.jail...@wanadoo.fr wrote: Hi, I was wondering if logged message, at least APLOG_ERR or APLOG_EMERG and APLOG_CRIT, should all have a corresponding APLOGNO()? Using the following regex:

Re: Question about APLOGNO

2014-07-19 Thread Eric Covener
On Sat, Jul 19, 2014 at 2:13 PM, Jeff Trawick traw...@gmail.com wrote: IMO anything more important than DEBUG needs a number, but I think even many DEBUG messages have numbers. +1 -- Eric Covener cove...@gmail.com

Re: Question about APLOGNO

2014-07-19 Thread Christophe JAILLET
Le 19/07/2014 20:04, Christophe JAILLET a écrit : I was wondering if logged message, at least APLOG_ERR or APLOG_EMERG and APLOG_CRIT, should all have a corresponding APLOGNO()? While updating code for that, I came across APLOG_NOERRNO which is defined as: /* APLOG_NOERRNO is ignored

Re: Question about APLOGNO

2014-07-19 Thread Eric Covener
On Sat, Jul 19, 2014 at 4:04 PM, Christophe JAILLET christophe.jail...@wanadoo.fr wrote: Why should it be removed in the future? Isn't it useful to self document the code when, for any reason, no APLOGNO should be appended ? I think you misinterpreted, it is not related to APLOGNO. You can see

Re: Question about APLOGNO

2014-07-19 Thread Christophe JAILLET
Le 19/07/2014 22:16, Eric Covener a écrit : On Sat, Jul 19, 2014 at 4:04 PM, Christophe JAILLET christophe.jail...@wanadoo.fr wrote: Why should it be removed in the future? Isn't it useful to self document the code when, for any reason, no APLOGNO should be appended ? I think you

Re: Question about APLOGNO

2014-07-19 Thread William A. Rowe Jr.
Spanning lines in regex tests is trivial. If it violates 80 col formatting style rule, absolutely do not shift the APLOGNO macro to the first line. Christophe JAILLET christophe.jail...@wanadoo.fr wrote: Hi, I was wondering if logged message, at least APLOG_ERR or APLOG_EMERG and APLOG_CRIT,